Open
Conversation
The existing behaviour auto-released the lock once the `schedule:run`command finished execution. For short running tasks (~1 second or less), auto-releasing the lock can lead to a case where if a cron starts slightly later on another server, the lock from the first invocation has already been deleted, and the task is executed for a second time. This change relies on the DEFAULT_TTL constant to tidy-up locks rather than doing so in this extension.
|
I'm glad you found this, because this saved me a couple of hours of figuring out why it wasn't working. Now i'm hoping this gets merged soon. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The existing behaviour auto-released the lock once the
schedule:runcommand finished execution.For short running tasks (~1 second or less), auto-releasing the lock can lead to a case where if a cron starts slightly later on another server, the lock from the first invocation has already been deleted, and the task is executed for a second time. For a cluster of 3 app servers running in the same datacenter using Redis to store locks, I've noticed this happening fairly frequenty on ~1 second jobs (~30% of the time).
This change relies on the DEFAULT_TTL constant to tidy-up locks rather than doing so in this extension. I'm not entirely sure this is the best way of handling things, so I'm open to other ideas!