d_meter_HIO Wii/debug mostly matching#3158
Open
caseif wants to merge 1 commit into
Open
Conversation
Report for Shield (b3cf239 - 7ecdbee)No changesReport for GZ2P01 (b3cf239 - 7ecdbee)No changesReport for GZ2E01 (b3cf239 - 7ecdbee)No changesReport for RZDE01_00 (b3cf239 - 7ecdbee)📈 Matched code: 47.02% (+0.16%, +17244 bytes) ✅ 45 new matches
...and 15 more new matches 📈 34 improvements in unmatched items
...and 4 more improvements in unmatched items Report for DZDE01 (b3cf239 - 7ecdbee)📈 Matched code: 52.19% (+0.09%, +9548 bytes) ✅ 57 new matches
...and 27 more new matches 📈 9 improvements in unmatched items
Report for GZ2J01 (b3cf239 - 7ecdbee)No changesReport for RZDE01_02 (b3cf239 - 7ecdbee)📈 Matched code: 54.64% (+0.12%, +12572 bytes) ✅ 59 new matches
...and 29 more new matches 📈 11 improvements in unmatched items
Report for RZDP01 (b3cf239 - 7ecdbee)📈 Matched code: 53.43% (+0.12%, +12572 bytes) ✅ 59 new matches
...and 29 more new matches 📈 10 improvements in unmatched items
Report for ShieldD (b3cf239 - 7ecdbee)📈 Matched code: 54.45% (+0.00%, +160 bytes) ✅ 4 new matches
Report for RZDJ01 (b3cf239 - 7ecdbee)📈 Matched code: 53.81% (+0.12%, +12580 bytes) ✅ 59 new matches
...and 29 more new matches 📈 7 improvements in unmatched items
|
caseif
force-pushed
the
d_meter_hio-debug
branch
from
dfdb614 to
f77dcf7
Compare
Contributor
Author
|
The |
Contributor
The regressions are 'real' in the sense that you changed the splits to increase the amount of data in that TU, which caused the percentages to go down because the total amount of data increased without increasing the amount of matching data. If you want objdiff to notice that the data matches to make the percentage go up, you would have to change the symbol names as well (since |
caseif
force-pushed
the
d_meter_hio-debug
branch
from
f77dcf7 to
7ecdbee
Compare
Contributor
Author
|
@LagoLunatic Oh I see, I had overlooked that aspect. I've added dummy symbol names for those symbols just for the sake of cleaning up the report. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR mostly matches
d_meter_HIOfor all Wii versions + ShieldD.