Skip to content

Wii PAL d_s_logo improvements#3157

Open
PJB3005 wants to merge 8 commits into
zeldaret:mainfrom
PJB3005:26-04-25-pal-wii-d_s_logo
Open

Wii PAL d_s_logo improvements#3157
PJB3005 wants to merge 8 commits into
zeldaret:mainfrom
PJB3005:26-04-25-pal-wii-d_s_logo

Conversation

@PJB3005
Copy link
Copy Markdown
Contributor

@PJB3005 PJB3005 commented Apr 24, 2026

No description provided.

@decomp-dev
Copy link
Copy Markdown

decomp-dev Bot commented Apr 24, 2026 •
edited
Loading

Report for GZ2P01 (b3cf239 - 7a8b4d3)

No changes

Report for RZDJ01 (b3cf239 - 7a8b4d3)

📈 Matched code: 53.71% (+0.02%, +2136 bytes)

✅ 4 new matches
Unit Item Bytes Before After
d_a_movie_player/d/actor/d_a_movie_player mDoGph_gInf_c::isWide() +24 0.00% 100.00%
d_a_balloon_2D/d/actor/d_a_balloon_2D daBalloon2D_c::setHIO(bool) +10 98.45% 100.00%
framework/d/d_msg_scrn_item dMsgScrnItem_c::drawSelf() +6 99.57% 100.00%
framework/d/d_camera dCamera_c::CalcTrimSize() +5 98.68% 100.00%
📈 5 improvements in unmatched items
Unit Item Bytes Before After
framework/d/d_meter_map dMeterMap_c::getMapDispEdgeLeftX_Layout() +33 20.24% 53.44%
framework/d/d_home_button dHomeButton_c::execute_() +27 91.16% 97.30%
framework/d/d_camera dCamera_c::chaseCamera(long) +17 95.69% 95.82%
framework/d/d_home_button drawCallback(J2DOrthoGraph&, void*) +5 98.28% 99.83%
framework/d/d_camera dCamera_c::rideCamera(long) +5 98.72% 98.77%

Report for Shield (b3cf239 - 7a8b4d3)

📈 10 improvements in unmatched items
Unit Item Bytes Before After
framework/d/d_meter_map dMeterMap_c::_move(unsigned long) +54 65.47% 71.54%
d_a_movie_player/d/actor/d_a_movie_player mDoGph_gInf_c::isWide() +23 0.00% 98.33%
framework/d/d_meter_map dMeterMap_c::_create(J2DScreen*) +22 90.07% 92.59%
framework/d/d_camera dCamera_c::chaseCamera(long) +17 99.81% 99.93%
framework/d/d_home_button dHomeButton_c::execute_() +12 94.02% 95.80%
d_a_balloon_2D/d/actor/d_a_balloon_2D daBalloon2D_c::setHIO(bool) +8 98.89% 99.95%
framework/d/d_s_logo dScnLogo_c::logoInitWii() +7 99.15% 99.97%
framework/d/d_camera dCamera_c::CalcTrimSize() +4 98.68% 99.95%
framework/d/d_camera dCamera_c::rideCamera(long) +4 99.46% 99.51%
framework/d/d_msg_scrn_item dMsgScrnItem_c::drawSelf() +4 99.42% 99.81%

Report for RZDP01 (b3cf239 - 7a8b4d3)

📈 Matched code: 53.58% (+0.27%, +27300 bytes)
📈 Matched data: 53.91% (+0.00%, +96 bytes)

✅ 58 new matches
Unit Item Bytes Before After
framework/d/d_s_logo dScnLogo_c::dvdDataLoad() +187 83.97% 100.00%
framework/d/d_s_logo dScnLogo_c::logoInitWii() +163 68.50% 100.00%
framework/d/d_s_logo phase_1(dScnLogo_c*) +155 65.83% 100.00%
framework/d/d_s_logo dScnLogo_c::~dScnLogo_c() +108 93.19% 100.00%
framework/d/d_s_logo dScnLogo_c::warningDispDraw() +76 75.60% 100.00%
framework/d/d_s_logo dScnLogo_c::setRenderMode() +69 19.05% 100.00%
d_a_movie_player/d/actor/d_a_movie_player mDoGph_gInf_c::isWide() +24 0.00% 100.00%
framework/d/d_s_logo .rodata +23 58.64% 100.00%
framework/d/d_s_logo dScnLogo_c::progChangeDraw() +10 92.33% 100.00%
d_a_balloon_2D/d/actor/d_a_balloon_2D daBalloon2D_c::setHIO(bool) +10 98.45% 100.00%
framework/d/d_camera dCamera_c::CalcTrimSize() +5 98.68% 100.00%
framework/d/d_s_logo dScnLogo_c::progOutDraw() +3 98.77% 100.00%
framework/d/d_s_logo dScnLogo_c::dvdWaitDraw() +2 99.81% 100.00%
d_a_npc_kakashi/d/actor/d_a_npc_kakashi daNpc_Kakashi_c::setStaggerParam(fopAc_ac_c*) +2 99.87% 100.00%
framework/d/d_home_button dHomeButton_c::onReset() +1 99.40% 100.00%
framework/m_Do/m_Do_machine myGetHeapTypeByString(JKRHeap*) +1 99.94% 100.00%
framework/m_Do/m_Do_machine fault_callback_scroll(unsigned short, OSContext*, unsigned long, unsigned long) +1 99.98% 100.00%
framework/d/d_file_select dFile_select_c::_create() +1 99.81% 100.00%
framework/d/d_s_logo dScnLogo_c::preLoad_dyl() +1 99.97% 100.00%
framework/d/d_s_logo dScnLogo_c::draw() +1 99.85% 100.00%
framework/d/d_s_logo dScnLogo_c::progInDraw() +1 99.83% 100.00%
framework/d/d_s_logo dScnLogo_c::progSetDraw() +1 99.88% 100.00%
framework/d/d_s_logo dScnLogo_c::progSet2Draw() +1 99.70% 100.00%
framework/d/d_s_logo dScnLogo_c::warningInDraw() +1 99.79% 100.00%
framework/d/d_s_logo dScnLogo_c::warningOutDraw() +1 99.88% 100.00%
framework/d/d_s_logo dScnLogo_c::nintendoInDraw() +1 99.88% 100.00%
framework/d/d_s_logo dScnLogo_c::nintendoOutDraw() +1 99.88% 100.00%
framework/d/d_s_logo dScnLogo_c::dolbyInDraw() +1 99.88% 100.00%
framework/d/d_s_logo dScnLogo_c::dolbyOutDraw() +1 99.88% 100.00%
framework/d/d_s_logo dScnLogo_c::dolbyOutDraw2() +1 99.67% 100.00%

...and 28 more new matches

📈 41 improvements in unmatched items
Unit Item Bytes Before After
framework/d/d_meter_map dMeterMap_c::getMapDispEdgeLeftX_Layout() +33 20.24% 53.44%
framework/d/d_home_button dHomeButton_c::execute_() +27 91.16% 97.30%
framework/m_Do/m_Do_machine .data +27 93.45% 96.39%
framework/d/d_s_logo .sdata +26 50.00% 81.82%
framework/d/d_s_name .rodata +21 0.00% 90.91%
framework/d/d_camera dCamera_c::chaseCamera(long) +17 95.69% 95.82%
framework/d/d_com_inf_game .data +14 36.57% 40.29%
framework/d/d_s_logo .sdata2 +7 80.00% 95.65%
framework/d/d_home_button drawCallback(J2DOrthoGraph&, void*) +5 98.28% 99.83%
framework/d/d_camera dCamera_c::rideCamera(long) +5 98.72% 98.77%
framework/d/d_msg_scrn_item dMsgScrnItem_c::drawSelf() +4 96.26% 96.53%
d_a_e_rd/d/actor/d_a_e_rd damage_check(e_rd_class*) +2 99.81% 99.85%
framework/d/d_gameover dGameover_c::_create() +1 99.79% 99.88%
framework/d/d_s_logo .data +1 24.90% 24.95%
framework/d/d_s_logo dScnLogo_c::progSelDraw() +1 82.27% 82.41%
framework/d/d_s_play .sbss +1 94.00% 96.00%
framework/d/d_s_play dScnPly_Delete(dScnPly_c*) +1 93.61% 93.65%
framework/d/d_s_play phase_1_0(dScnPly_c*) +1 99.44% 99.78%
framework/d/d_s_room objectSetCheck(room_of_scene_class*) +1 99.25% 99.34%
d_a_ep/d/actor/d_a_ep daEp_Execute(ep_class*) +1 93.58% 93.59%
d_a_e_mf/d/actor/d_a_e_mf daE_MF_Execute(e_mf_class*) +1 93.70% 93.71%
d_a_e_oct_bg/d/actor/d_a_e_oct_bg daE_OctBg_c::damage_check() +1 97.00% 97.07%
d_a_e_yk/d/actor/d_a_e_yk action(e_yk_class*) +1 99.26% 99.27%
d_a_obj_kbox/d/actor/d_a_obj_kbox daObj_Kbox_Execute(obj_kbox_class*) +1 93.63% 93.64%
framework/m_Do/m_Do_graphic mDoGph_Painter() 0 97.76% 97.76%
framework/m_Do/m_Do_machine myExceptionCallback(unsigned short, OSContext*, unsigned long, unsigned long) 0 94.41% 94.45%
framework/d/d_com_inf_game dComIfG_changeOpeningScene(scene_class*, short) 0 99.69% 99.92%
framework/d/d_cc_uty cc_at_check(fopAc_ac_c*, dCcU_AtInfo*) 0 98.42% 98.44%
framework/d/d_s_name dScnName_c::~dScnName_c() 0 74.19% 74.32%
framework/d/d_s_room dScnRoom_Execute(room_of_scene_class*) 0 98.97% 99.05%

...and 11 more improvements in unmatched items

Report for GZ2E01 (b3cf239 - 7a8b4d3)

No changes

Report for DZDE01 (b3cf239 - 7a8b4d3)

📈 7 improvements in unmatched items
Unit Item Bytes Before After
framework/d/d_meter_map dMeterMap_c::getMapDispEdgeLeftX_Layout() +33 20.24% 53.24%
d_a_movie_player/d/actor/d_a_movie_player mDoGph_gInf_c::isWide() +23 0.00% 98.33%
framework/d/d_camera dCamera_c::chaseCamera(long) +16 95.69% 95.82%
d_a_balloon_2D/d/actor/d_a_balloon_2D daBalloon2D_c::setHIO(bool) +9 98.45% 99.93%
framework/d/d_camera dCamera_c::rideCamera(long) +5 98.72% 98.77%
framework/d/d_msg_scrn_item dMsgScrnItem_c::drawSelf() +5 99.57% 99.98%
framework/d/d_camera dCamera_c::CalcTrimSize() +4 98.68% 99.95%

Report for RZDE01_00 (b3cf239 - 7a8b4d3)

📈 Matched code: 46.87% (+0.01%, +1520 bytes)

✅ 4 new matches
Unit Item Bytes Before After
d_a_movie_player/d/actor/d_a_movie_player mDoGph_gInf_c::isWide() +24 0.00% 100.00%
framework/d/d_s_logo dScnLogo_c::logoInitWii() +12 97.80% 100.00%
d_a_balloon_2D/d/actor/d_a_balloon_2D daBalloon2D_c::setHIO(bool) +10 98.45% 100.00%
framework/d/d_camera dCamera_c::CalcTrimSize() +5 98.68% 100.00%
📈 6 improvements in unmatched items
Unit Item Bytes Before After
framework/d/d_meter_map dMeterMap_c::getMapDispEdgeLeftX_Layout() +33 20.24% 53.44%
framework/d/d_home_button dHomeButton_c::execute_() +27 91.16% 97.30%
framework/d/d_camera dCamera_c::chaseCamera(long) +17 95.69% 95.82%
framework/d/d_home_button drawCallback(J2DOrthoGraph&, void*) +5 98.28% 99.83%
framework/d/d_camera dCamera_c::rideCamera(long) +5 98.72% 98.77%
framework/d/d_msg_scrn_item dMsgScrnItem_c::drawSelf() +3 96.36% 96.62%

Report for RZDE01_02 (b3cf239 - 7a8b4d3)

📈 Matched code: 54.54% (+0.03%, +2672 bytes)

✅ 5 new matches
Unit Item Bytes Before After
d_a_movie_player/d/actor/d_a_movie_player mDoGph_gInf_c::isWide() +24 0.00% 100.00%
framework/d/d_s_logo dScnLogo_c::logoInitWii() +12 97.80% 100.00%
d_a_balloon_2D/d/actor/d_a_balloon_2D daBalloon2D_c::setHIO(bool) +10 98.45% 100.00%
framework/d/d_msg_scrn_item dMsgScrnItem_c::drawSelf() +6 99.57% 100.00%
framework/d/d_camera dCamera_c::CalcTrimSize() +5 98.68% 100.00%
📈 5 improvements in unmatched items
Unit Item Bytes Before After
framework/d/d_meter_map dMeterMap_c::getMapDispEdgeLeftX_Layout() +33 20.24% 53.44%
framework/d/d_home_button dHomeButton_c::execute_() +27 91.16% 97.30%
framework/d/d_camera dCamera_c::chaseCamera(long) +17 95.69% 95.82%
framework/d/d_home_button drawCallback(J2DOrthoGraph&, void*) +5 98.28% 99.83%
framework/d/d_camera dCamera_c::rideCamera(long) +5 98.72% 98.77%

Report for GZ2J01 (b3cf239 - 7a8b4d3)

No changes

Report for ShieldD (b3cf239 - 7a8b4d3)

📈 Matched code: 54.45% (+0.00%, +688 bytes)

✅ 1 new match
Unit Item Bytes Before After
framework/d/d_s_logo dScnLogo_c::logoInitWii() +1 99.99% 100.00%

@PJB3005
Copy link
Copy Markdown
Contributor Author

PJB3005 commented Apr 25, 2026

report seems to not have regenerated after last push. I think I fixed the regressions though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@PJB3005