Decompile overlay 24 (Part 1) by Yanis002 · Pull Request #65 · zeldaret/st

Yanis002 · 2026-05-12T00:16:57Z

No description provided.

decomp-dev · 2026-05-12T00:18:08Z

Report for jp (`0f74fd4` - `bb7bc0c`)

📈 Matched code: 4.79% (+0.68%, +31172 bytes)
📈 Linked code: 1.10% (+0.67%, +31002 bytes)
📈 Matched data: 23.56% (+0.08%, +1108 bytes)
📈 Linked data: 0.42% (+0.10%, +1304 bytes)

✅ 360 new matches

Unit	Item	Bytes	Before	After
`src/024_MainGame/Game/AdventureModeManager_024`	`AdventureModeManager::vfunc_24()`	+1844	0.00%	100.00%
`src/024_MainGame/Game/AdventureModeManager_160_024`	`AdventureModeManager_160::vfunc_1C(int)`	+876	0.00%	100.00%
`src/024_MainGame/Game/AdventureModeManager_15C_20_00_024`	`AdventureModeManager_15C_20_00::vfunc_08(Input, TouchControl)`	+720	0.00%	100.00%
`src/001_SceneInit/Game/AdventureModeManager_001`	`AdventureModeManager::vfunc_18()`	+584	0.00%	100.00%
`src/024_MainGame/Game/AdventureModeManager_174_Base_024`	`AdventureModeManager_174_Base::func_ov024_020c88f0()`	+572	0.00%	100.00%
`src/024_MainGame/Game/AdventureModeManager_1B8_Base_024`	`AdventureModeManager_1B8_Base::func_ov024_020d0a64()`	+568	0.00%	100.00%
`src/024_MainGame/Game/AdventureModeManager_1B8_Base_024`	`AdventureModeManager_1B8::func_ov024_020d1160()`	+516	0.00%	100.00%
`src/024_MainGame/Game/UnkStruct_027e0998_024`	`UnkStruct_027e0998::vfunc_00(Vec3p, Vec2s, unsigned short*)`	+480	0.00%	100.00%
`src/024_MainGame/Game/AdventureModeManager_1B8_Base_024`	`AdventureModeManager_1B8_Base::func_ov024_020d0744(int, int, int, int, unsigned char, unsigned char)`	+480	0.00%	100.00%
`src/024_MainGame/Game/AdventureModeManager_174_Base_024`	`AdventureModeManager_174_Base::func_ov024_020c8b2c()`	+468	0.00%	100.00%
`src/024_MainGame/Game/AdventureModeManager_18C_024`	`AdventureModeManager_18C::vfunc_20(int, int)`	+452	0.00%	100.00%
`src/024_MainGame/Game/AdventureModeManager_160_024`	`AdventureModeManager_160::vfunc_0C(int)`	+416	0.00%	100.00%
`src/024_MainGame/Game/AdventureModeManager_1B8_Base_024`	`AdventureModeManager_1B8::func_ov024_020d0fb4(int, int, unsigned char, unsigned char, TouchControl*)`	+408	0.00%	100.00%
`src/024_MainGame/Game/AdventureModeManager_024`	`AdventureModeManager::func_ov024_020c5f70()`	+388	0.00%	100.00%
`src/024_MainGame/Game/AdventureModeManager_024`	`AdventureModeManager::func_ov024_020c53e8()`	+372	0.00%	100.00%
`src/024_MainGame/Game/AdventureModeManager_15C_20_00_024`	`AdventureModeManager_15C_20_00::AdventureModeManager_15C_20_00(bool)`	+364	0.00%	100.00%
`src/024_MainGame/Game/AdventureModeManager_024`	`AdventureModeManager::func_ov024_020c6514(unsigned int, unsigned char, short, short)`	+352	0.00%	100.00%
`src/024_MainGame/Game/UnkStruct_027e0cf8_024`	`UnkStruct_027e0cf8::func_ov024_020c75d0(void*, int, unsigned short)`	+340	0.00%	100.00%
`src/024_MainGame/Game/AdventureModeManager_024`	`AdventureModeManager::func_ov024_020c60f4()`	+328	0.00%	100.00%
`src/024_MainGame/Game/AdventureModeManager_1B8_Base_024`	`AdventureModeManager_1B8_Base::func_ov024_020d0924(int, int, unsigned char, unsigned char)`	+320	0.00%	100.00%
`src/024_MainGame/Game/AdventureModeManager_15C_20_00_024`	`AdventureModeManager_15C_20_00::func_ov024_020ca48c()`	+316	0.00%	100.00%
`src/024_MainGame/Game/AdventureModeManager_024`	`AdventureModeManager::vfunc_2C(char*)`	+312	0.00%	100.00%
`src/001_SceneInit/Game/AdventureModeManager_001`	`AdventureModeManager::AdventureModeManager(int)`	+308	0.00%	100.00%
`src/024_MainGame/Game/UnkStruct_ov000_020d8660_024`	`UnkStruct_ov024_020d8660::func_ov024_020c4ba0()`	+296	0.00%	100.00%
`src/024_MainGame/Game/AdventureModeManager_024`	`AdventureModeManager::func_ov024_020c5dac()`	+288	0.00%	100.00%
`src/024_MainGame/Game/AdventureModeManager_160_024`	`AdventureModeManager_160::vfunc_18(int)`	+280	0.00%	100.00%
`src/024_MainGame/Game/AdventureModeManager_1B8_Base_024`	`AdventureModeManager_1B8_Base::TryLoadBGChar(void*, unsigned int, unsigned int)`	+280	0.00%	100.00%
`src/024_MainGame/Game/UnkActorSystem2_024`	`UnkActorSystem2::vfunc_10(char*)`	+252	0.00%	100.00%
`src/024_MainGame/Game/AdventureModeManager_160_024`	`AdventureModeManager_160::vfunc_20(int, int)`	+248	0.00%	100.00%
`src/024_MainGame/Game/AdventureModeManager_184_024`	`AdventureModeManager_184::vfunc_0C(int)`	+248	0.00%	100.00%

...and 330 more new matches

🥀 16 broken matches

Unit	Item	Bytes	Before	After
`src/019_MainSelect/FileSelectManager_160`	`FileSelectManager_160::vfunc_20()`	-172	100.00%	0.00%
`src/019_MainSelect/FileSelectManager_164`	`FileSelectManager_164::vfunc_10()`	-168	100.00%	0.00%
`src/019_MainSelect/FileSelectManager_164`	`FileSelectManager_164::vfunc_20()`	-144	100.00%	0.00%
`src/019_MainSelect/FileSelectManager_160`	`FileSelectManager_160::vfunc_10()`	-140	100.00%	0.00%
`src/Main/Game/GameModeManagerBase`	`GameModeManagerBase::vfunc_04()`	-40	100.00%	0.00%
`src/024_MainGame/MiscAdvManager`	`MiscAdvManager::ClearInstance()`	-20	100.00%	0.00%
`src/024_MainGame/MiscAdvManager`	`MiscAdvManager::SetInstance(MiscAdvManager*)`	-16	100.00%	0.00%
`src/001_SceneInit/Actor/ActorManager_001`	`ActorManager::SetInstance(ActorManager*)`	-12	100.00%	0.00%
`src/001_SceneInit/Actor/ActorManager_001`	`ActorManager::ClearInstance()`	-12	100.00%	0.00%
`src/001_SceneInit/CargoManager_001`	`CargoManager::SetInstance(CargoManager*)`	-12	100.00%	0.00%
`src/001_SceneInit/CargoManager_001`	`CargoManager::ClearInstance()`	-12	100.00%	0.00%
`src/001_SceneInit/PassengerManager_001`	`PassengerManager::SetInstance(PassengerManager*)`	-12	100.00%	0.00%
`src/001_SceneInit/PassengerManager_001`	`PassengerManager::ClearInstance()`	-12	100.00%	0.00%
`src/019_MainSelect/FileSelectManager_160`	`FileSelectManager_160::vfunc_14()`	-4	100.00%	0.00%
`src/019_MainSelect/FileSelectManager_164`	`FileSelectManager_164::vfunc_14()`	-4	100.00%	0.00%
`src/025_Title/TitleScreenManager`	`TitleScreenManager::vfunc_38(int, int, int, int)`	-4	100.00%	0.00%

📈 9 improvements in unmatched items

Unit	Item	Bytes	Before	After
`src/001_SceneInit/Game/AdventureModeManager_001`	`AdventureModeManager::vfunc_14()`	+861	0.00%	99.21%
`src/024_MainGame/Game/AdventureModeManager_18C_024`	`AdventureModeManager_18C::vfunc_10(int, int)`	+255	0.00%	99.91%
`src/024_MainGame/Game/AdventureModeManager_180_024`	`AdventureModeManager_180::vfunc_10(int, int)`	+99	0.00%	99.88%
`src/019_MainSelect/FileSelectMain`	`FileSelectMain::func_ov019_020ca940()`	+37	91.72%	93.50%
`src/019_MainSelect/FileSelectMain`	`FileSelectMain::func_ov019_020c9e08()`	+31	90.48%	91.88%
`src/019_MainSelect/FileSelectMain`	`FileSelectMain::func_ov019_020c8c4c()`	+19	98.86%	99.97%
`src/019_MainSelect/FileSelectMain`	`FileSelectMain::func_ov019_020c854c()`	+16	98.83%	99.97%
`src/019_MainSelect/019_UnkSubStruct9`	`UnkSubStruct9::UnkSubStruct9(stack_struct1)`	+4	96.13%	96.58%
`src/019_MainSelect/FileSelectOptions`	`FileSelectOptions::func_ov019_020cd8d4()`	+1	99.78%	99.98%

📉 3 regressions in unmatched items

Unit	Item	Bytes	Before	After
`src/019_MainSelect/FileSelectMain`	`.data`	-603	95.33%	18.37%
`src/019_MainSelect/FileSelectMain`	`FileSelectMain::func_ov019_020c92dc()`	-22	93.26%	92.19%
`src/019_MainSelect/FileSelectMain`	`FileSelectMain::FileSelectMain()`	-12	46.20%	45.72%

Report for eur (`0f74fd4` - `bb7bc0c`)

Total code: 4587358 bytes (+7068 bytes)
Total functions: 32526 (+49)
📈 Matched code: 4.83% (+0.67%, +31124 bytes)
📈 Linked code: 1.24% (+0.67%, +30954 bytes)
Total data: 1346536 bytes (-7068 bytes)
📈 Matched data: 23.67% (+0.21%, +1108 bytes)
📈 Linked data: 0.46% (+0.10%, +1304 bytes)

✅ 362 new matches

Unit	Item	Bytes	Before	After
`src/024_MainGame/Game/AdventureModeManager_024`	`AdventureModeManager::vfunc_24()`	+1928	0.00%	100.00%
`src/024_MainGame/Game/AdventureModeManager_160_024`	`AdventureModeManager_160::vfunc_1C(int)`	+876	0.00%	100.00%
`src/024_MainGame/Game/AdventureModeManager_15C_20_00_024`	`AdventureModeManager_15C_20_00::vfunc_08(Input, TouchControl)`	+720	0.00%	100.00%
`src/001_SceneInit/Game/AdventureModeManager_001`	`AdventureModeManager::vfunc_18()`	+584	0.00%	100.00%
`src/024_MainGame/Game/AdventureModeManager_174_Base_024`	`AdventureModeManager_174_Base::func_ov024_020c88f0()`	+572	0.00%	100.00%
`src/024_MainGame/Game/AdventureModeManager_1B8_Base_024`	`AdventureModeManager_1B8_Base::func_ov024_020d0a64()`	+568	0.00%	100.00%
`src/024_MainGame/Game/AdventureModeManager_1B8_Base_024`	`AdventureModeManager_1B8::func_ov024_020d1160()`	+516	0.00%	100.00%
`src/024_MainGame/Game/UnkStruct_027e0998_024`	`UnkStruct_027e0998::vfunc_00(Vec3p, Vec2s, unsigned short*)`	+480	0.00%	100.00%
`src/024_MainGame/Game/AdventureModeManager_1B8_Base_024`	`AdventureModeManager_1B8_Base::func_ov024_020d0744(int, int, int, int, unsigned char, unsigned char)`	+480	0.00%	100.00%
`src/024_MainGame/Game/AdventureModeManager_174_Base_024`	`AdventureModeManager_174_Base::func_ov024_020c8b2c()`	+468	0.00%	100.00%
`src/024_MainGame/Game/AdventureModeManager_18C_024`	`AdventureModeManager_18C::vfunc_20(int, int)`	+452	0.00%	100.00%
`src/024_MainGame/Game/AdventureModeManager_160_024`	`AdventureModeManager_160::vfunc_0C(int)`	+416	0.00%	100.00%
`src/024_MainGame/Game/AdventureModeManager_1B8_Base_024`	`AdventureModeManager_1B8::func_ov024_020d0fb4(int, int, unsigned char, unsigned char, TouchControl*)`	+408	0.00%	100.00%
`src/024_MainGame/Game/AdventureModeManager_024`	`AdventureModeManager::func_ov024_020c5f70()`	+388	0.00%	100.00%
`src/024_MainGame/Game/AdventureModeManager_024`	`AdventureModeManager::func_ov024_020c53e8()`	+372	0.00%	100.00%
`src/024_MainGame/Game/AdventureModeManager_15C_20_00_024`	`AdventureModeManager_15C_20_00::AdventureModeManager_15C_20_00(bool)`	+364	0.00%	100.00%
`src/024_MainGame/Game/AdventureModeManager_024`	`AdventureModeManager::func_ov024_020c6514(unsigned int, unsigned char, short, short)`	+352	0.00%	100.00%
`src/024_MainGame/Game/UnkStruct_027e0cf8_024`	`UnkStruct_027e0cf8::func_ov024_020c75d0(void*, int, unsigned short)`	+340	0.00%	100.00%
`src/024_MainGame/Game/AdventureModeManager_024`	`AdventureModeManager::func_ov024_020c60f4()`	+328	0.00%	100.00%
`src/024_MainGame/Game/AdventureModeManager_1B8_Base_024`	`AdventureModeManager_1B8_Base::func_ov024_020d0924(int, int, unsigned char, unsigned char)`	+320	0.00%	100.00%
`src/024_MainGame/Game/AdventureModeManager_15C_20_00_024`	`AdventureModeManager_15C_20_00::func_ov024_020ca48c()`	+316	0.00%	100.00%
`src/024_MainGame/Game/AdventureModeManager_024`	`AdventureModeManager::vfunc_2C(char*)`	+312	0.00%	100.00%
`src/001_SceneInit/Game/AdventureModeManager_001`	`AdventureModeManager::AdventureModeManager(int)`	+308	0.00%	100.00%
`src/024_MainGame/Game/UnkStruct_ov000_020d8660_024`	`UnkStruct_ov024_020d8660::func_ov024_020c4ba0()`	+296	0.00%	100.00%
`src/024_MainGame/Game/AdventureModeManager_024`	`AdventureModeManager::func_ov024_020c5dac()`	+288	0.00%	100.00%
`src/024_MainGame/Game/AdventureModeManager_160_024`	`AdventureModeManager_160::vfunc_18(int)`	+280	0.00%	100.00%
`src/024_MainGame/Game/AdventureModeManager_1B8_Base_024`	`AdventureModeManager_1B8_Base::TryLoadBGChar(void*, unsigned int, unsigned int)`	+280	0.00%	100.00%
`src/024_MainGame/Game/UnkActorSystem2_024`	`UnkActorSystem2::vfunc_10(char*)`	+252	0.00%	100.00%
`src/024_MainGame/Game/AdventureModeManager_160_024`	`AdventureModeManager_160::vfunc_20(int, int)`	+248	0.00%	100.00%
`src/024_MainGame/Game/AdventureModeManager_184_024`	`AdventureModeManager_184::vfunc_0C(int)`	+248	0.00%	100.00%

...and 332 more new matches

🥀 18 broken matches

Unit	Item	Bytes	Before	After
`src/019_MainSelect/FileSelectManager_160`	`FileSelectManager_160::vfunc_20()`	-172	100.00%	0.00%
`src/019_MainSelect/FileSelectManager_164`	`FileSelectManager_164::vfunc_10()`	-168	100.00%	0.00%
`src/019_MainSelect/FileSelectManager_164`	`FileSelectManager_164::vfunc_20()`	-144	100.00%	0.00%
`src/019_MainSelect/FileSelectManager_160`	`FileSelectManager_160::vfunc_10()`	-140	100.00%	0.00%
`src/Main/Game/GameModeManagerBase`	`GameModeManagerBase::vfunc_04()`	-40	100.00%	0.00%
`src/000_Second/Item/TreasureManager`	`TreasureManager::func_ov000_020aa210()`	-20	100.00%	0.00%
`src/024_MainGame/MiscAdvManager`	`MiscAdvManager::ClearInstance()`	-20	100.00%	0.00%
`src/000_Second/Item/TreasureManager`	`TreasureManager::func_ov000_020aa200()`	-16	100.00%	0.00%
`src/024_MainGame/MiscAdvManager`	`MiscAdvManager::SetInstance(MiscAdvManager*)`	-16	100.00%	0.00%
`src/001_SceneInit/Actor/ActorManager_001`	`ActorManager::SetInstance(ActorManager*)`	-12	100.00%	0.00%
`src/001_SceneInit/Actor/ActorManager_001`	`ActorManager::ClearInstance()`	-12	100.00%	0.00%
`src/001_SceneInit/CargoManager_001`	`CargoManager::SetInstance(CargoManager*)`	-12	100.00%	0.00%
`src/001_SceneInit/CargoManager_001`	`CargoManager::ClearInstance()`	-12	100.00%	0.00%
`src/001_SceneInit/PassengerManager_001`	`PassengerManager::SetInstance(PassengerManager*)`	-12	100.00%	0.00%
`src/001_SceneInit/PassengerManager_001`	`PassengerManager::ClearInstance()`	-12	100.00%	0.00%
`src/019_MainSelect/FileSelectManager_160`	`FileSelectManager_160::vfunc_14()`	-4	100.00%	0.00%
`src/019_MainSelect/FileSelectManager_164`	`FileSelectManager_164::vfunc_14()`	-4	100.00%	0.00%
`src/025_Title/TitleScreenManager`	`TitleScreenManager::vfunc_38(int, int, int, int)`	-4	100.00%	0.00%

📈 9 improvements in unmatched items

Unit	Item	Bytes	Before	After
`src/001_SceneInit/Game/AdventureModeManager_001`	`AdventureModeManager::vfunc_14()`	+861	0.00%	99.21%
`src/024_MainGame/Game/AdventureModeManager_18C_024`	`AdventureModeManager_18C::vfunc_10(int, int)`	+255	0.00%	99.91%
`src/024_MainGame/Game/AdventureModeManager_180_024`	`AdventureModeManager_180::vfunc_10(int, int)`	+99	0.00%	99.88%
`src/019_MainSelect/FileSelectMain`	`FileSelectMain::func_ov019_020ca940()`	+37	91.72%	93.50%
`src/019_MainSelect/FileSelectMain`	`FileSelectMain::func_ov019_020c9e08()`	+31	90.48%	91.88%
`src/019_MainSelect/FileSelectMain`	`FileSelectMain::func_ov019_020c8c4c()`	+19	98.86%	99.97%
`src/019_MainSelect/FileSelectMain`	`FileSelectMain::func_ov019_020c854c()`	+16	98.83%	99.97%
`src/019_MainSelect/019_UnkSubStruct9`	`UnkSubStruct9::UnkSubStruct9(stack_struct1)`	+4	96.13%	96.58%
`src/019_MainSelect/FileSelectOptions`	`FileSelectOptions::func_ov019_020cd8d4()`	+1	99.78%	99.98%

📉 3 regressions in unmatched items

Unit	Item	Bytes	Before	After
`src/019_MainSelect/FileSelectMain`	`.data`	-51	95.33%	88.78%
`src/019_MainSelect/FileSelectMain`	`FileSelectMain::func_ov019_020c92dc()`	-22	93.26%	92.19%
`src/019_MainSelect/FileSelectMain`	`FileSelectMain::FileSelectMain()`	-12	46.20%	45.72%

…020d8660_024 OK

Yanis002 · 2026-05-18T19:13:39Z

I'm aware of the regressions but it's in function that needs to be worked on again anyway so whatever for now, that's a problem for future me™ (I don't really wanna go back to the file select for now)

GameModeAdventure_001 OK

4972445

Yanis002 added 19 commits May 12, 2026 04:16

GameModeAdventure_024 17%

ba8f770

GameModeAdventure_024 73%

573c7aa

GameModeAdventure_024 99%

278ba91

jp region differences

aec7e76

rename GameModeAdventure_024 and GameModeAdventure + UnkStruct_ov000_…

7333b9c

…020d8660_024 OK

UnkActorSystem1OK

9d8347b

UnkActorSystem2 OK

249dbe5

delink more of ov024 & UnkStruct_027e0998_024 OK

2bf02c2

improve instance stuff & UnkStruct_027e0cf8_024 OK

e37db3d

AdventureModeManager_160_024 OK & GameModeStartUp OK

c695834

fix regressions

212da80

fix regressions 2

fb8cace

AdventureModeManager_170 OK

5f5a5c2

AdventureModeManager_174_Base OK

5f9c5d7

AdventureModeManager_174 OK

68136af

mark GameModeAdventure_024 as complete

8ed77fe

AdventureModeManager_178 OK

6e61f90

AdventureModeManager_180 OK

0f0e46d

AdventureModeManager_184_024 OK

a4e52c8

Yanis002 changed the title ~~Decompile Game Mode Adventure~~ Decompile overlay 24 May 15, 2026

AdventureModeManager_18C_024 OK & AdventureModeManager_190_024 OK

53adb2d

Yanis002 force-pushed the gamemodeadv branch from 49f9240 to 53adb2d Compare May 15, 2026 23:54

Yanis002 added 4 commits May 16, 2026 04:14

AdventureModeManager_15C_20_00 61%

4818f17

AdventureModeManager_15C_20_00 OK

69bd742

jp version differences

f12f6a4

delink what's left in the overlay

ae9a9c9

Yanis002 changed the title ~~Decompile overlay 24~~ Decompile overlay 24 (Part 1) May 17, 2026

fix regressions

52d163b

Yanis002 added 5 commits May 18, 2026 00:14

AdventureModeManager_1B8_Base_024 98%

9cf3a90

AdventureModeManager_1B8 48% and link AdventureModeManager_024

fce4970

AdventureModeManager_1B8_Base and AdventureModeManager_1B8 OK

9f44957

oops

d92de51

mark statics as local

bb7bc0c

Yanis002 marked this pull request as ready for review May 18, 2026 19:06

Yanis002 merged commit 9020340 into zeldaret:main May 18, 2026
3 checks passed

Yanis002 deleted the gamemodeadv branch May 18, 2026 19:14

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Decompile overlay 24 (Part 1)#65

Decompile overlay 24 (Part 1)#65
Yanis002 merged 31 commits into
zeldaret:mainfrom
Yanis002:gamemodeadv

Yanis002 commented May 12, 2026

Uh oh!

decomp-dev Bot commented May 12, 2026 •

edited

Loading

Uh oh!

Yanis002 commented May 18, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Conversation

Yanis002 commented May 12, 2026

Uh oh!

decomp-dev Bot commented May 12, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Report for jp (0f74fd4 - bb7bc0c)

Report for eur (0f74fd4 - bb7bc0c)

Uh oh!

Yanis002 commented May 18, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

decomp-dev Bot commented May 12, 2026 •

edited

Loading

Report for jp (`0f74fd4` - `bb7bc0c`)

Report for eur (`0f74fd4` - `bb7bc0c`)