Skip serialized variants during type trace#91
Open
avvlas wants to merge 1 commit intozefchain:mainfrom
Open
Conversation
Contributor
Author
|
Hey, @ma2bd! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The tracer now records enum variants whose serialized VariantFormat is already complete, and deserialize_enum skips re-exploring those variants during type tracing. That avoids overwriting a complete serialized shape with a less precise deserialization-derived shape, while still allowing partially traced variants to be revisited and completed.
Motivation:
This change fixes the issue that can be reproduced with test:
test_trace_type_skips_fully_serialized_bytes_variantIn mixed tracing flows, an enum variant may already be fully learned from
trace_valuebeforetrace_typeruns. For example, if tracing first seesMessage::Send(Exact16([7; 16])), serialization can already determine that the variant payload is Bytes. During a latertrace_type::<Message>(), re-exploringSendthrough deserialization is unnecessary and can be actively harmful, because the deserializer only has synthetic placeholder input and may fail or infer a weaker shape.Test Plan
Tests added:
test_trace_type_revisits_partially_serialized_enum_variantstest_trace_type_skips_fully_serialized_bytes_variant