Skip to content

[windows] fix spicy build#145

Merged
timwoj merged 2 commits intozeek:masterfrom
mamaorha:ms/windows/spicy
Apr 6, 2026
Merged

[windows] fix spicy build#145
timwoj merged 2 commits intozeek:masterfrom
mamaorha:ms/windows/spicy

Conversation

@mamaorha
Copy link
Copy Markdown

No description provided.

@mamaorha mamaorha marked this pull request as ready for review March 11, 2026 07:16
Copy link
Copy Markdown
Member

@ckreibich ckreibich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! LGTM but I'll defer to @bbannier since he knows the Spicy-side cmake much better than I do.

Copy link
Copy Markdown
Member

@bbannier bbannier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks reasonable to me.

I haven't validated the packaging stuff, is that something we could check before merging @0xxon?

@0xxon
Copy link
Copy Markdown
Member

0xxon commented Apr 1, 2026

A build for this is now running in https://build.opensuse.org/package/show/home:0xxon:branches:security:zeek/zeek-nightly

Sorry for the delay

@timwoj
Copy link
Copy Markdown
Member

timwoj commented Apr 2, 2026

It looks like most of the builds passed, and the ones that failed aren't related to the changes here.

@timwoj timwoj merged commit 1e52f45 into zeek:master Apr 6, 2026
2 checks passed
@mamaorha mamaorha deleted the ms/windows/spicy branch April 7, 2026 05:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants