Add deadlock detection middleware for VirtualObjects#1
Open
yshaul wants to merge 1 commit into
Open
Conversation
…cture Adds an invocation middleware system that wraps handler execution at the SDK level (distinct from Rack HTTP middleware). Includes both inbound (handler wrapping) and outbound (service-to-service call) middleware hooks, registered via `use` and `use_outbound` on the endpoint. Ships a built-in DeadlockDetection middleware that catches re-entrant VirtualObject calls that would otherwise block forever. When an exclusive handler on VO key "x" calls another exclusive handler on the same key, the middleware raises a DeadlockError (409) immediately instead of silently hanging. Includes tests, an example, and README documentation. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
use) and outbound service calls (use_outbound) at the Restate protocol level (distinct from Rack HTTP middleware)DeadlockError(409) immediately instead of silently hangingexamples/middleware/deadlock_detection.rb), and README documentationHow it works
Restate VirtualObjects serialize exclusive handler access per key. If handler A on key "x" calls handler B on the same VO key "x", the second call waits for the first to finish — which never happens. The middleware tracks held locks via a header (
x-restate-held-locks) propagated through the call chain:DeadlockError; otherwise appends the lockTest plan
Made with Cursor