Changing %b to %s#38
Open
cthulhuology wants to merge 5 commits into
Open
Conversation
%b -> %s miscellaneous &1 not in capture converted to parameter etc.
Owner
|
Thanks for sending this in — it has been a great deal of challenge for me to bring expm up to date. I've done a big chunk of work recently and appreciate your help. Lets get through some details and I'll merge it in soon. |
Author
|
mix.lock wipeout was due to I repointed one of the dependencies at mine and had to clear the lock to use my fix to the lagerex module. You can cherry pick that one out. |
Author
|
I'm evaluating running my own expm repo for a project I'm working on, and can spare a few cycles to help. Let me know if you have anything in particular you need doing. |
Owner
|
I am overloaded, so if you can make this PR clean (no wipeout), it'll help me a lot! |
Fix first-time compilation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changing the binary sigil from %b to %s as per Elixir master. Seems to work :)