feat(ui): abstract Bible reader theme settings for RN#227
Draft
Dustin-Kelley wants to merge 5 commits intomainfrom
Draft
feat(ui): abstract Bible reader theme settings for RN#227Dustin-Kelley wants to merge 5 commits intomainfrom
Dustin-Kelley wants to merge 5 commits intomainfrom
Conversation
Export BibleThemeSettingsContent, add Toolbar onOpenBibleThemeSettings override with semantic font actions, and add unit tests. Co-authored-by: Cursor <cursoragent@cursor.com>
🦋 Changeset detectedLatest commit: 8f1caa5 The changes in this PR will be included in the next version bump. This PR includes changesets to release 4 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
…ttings to Toolbar
…Toolbar for consistency
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
BibleThemeSettingsContentand related types for reuse (e.g. RN Expo SDK).onOpenBibleThemeSettingsonBibleReader.Toolbarto bypass the web popover and receive a payload with current font settings and semantic actions (onFontIncreased,onFontDecreased,onFontSelected).Test plan
pnpm --filter @youversion/platform-react-ui test -- bible-reader.test.tsxMade with Cursor