fix(parse): always emit permissions: {} in workflow YAML output#9
Merged
Conversation
When no permissions block is present in HCL, the workflow now emits
permissions: {} (deny all) rather than omitting the key. An empty
permissions {} block already emitted {} after the previous fix, but
the global ": {}\n" → ":\n" post-processor in marshalWorkflowYAML was
silently erasing it. Fixed with a sentinel-swap that protects
permissions: {} through the strip.
All 14 affected golden fixtures updated. Explicit unit tests added
(TestParsePermissionsDefault) covering: no block, empty block, and
scoped permissions.
Go test coverage: 64.9% for commit 827fa38
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When no permissions block is present in HCL, the workflow now emits permissions: {} (deny all) rather than omitting the key. An empty permissions {} block already emitted {} after the previous fix, but the global ": {}\n" → ":\n" post-processor in marshalWorkflowYAML was silently erasing it. Fixed with a sentinel-swap that protects permissions: {} through the strip.
All 14 affected golden fixtures updated. Explicit unit tests added (TestParsePermissionsDefault) covering: no block, empty block, and scoped permissions.