fix: preserve HCL-defined job order in parse direction YAML output#7
Merged
Conversation
Replace the goccy/go-yaml parse in parseYAMLDocument with a single yaml.v3 Node API pass: yamlv3.Unmarshal into *Node, then node.Decode for map[string]any and node.Content walk for source key order. Eliminates the prior double-parse and keeps both views consistent. Also move jobOrder from YAMLDocument struct to an explicit parameter on workflowToHCL, and add a clear presence-check error in buildWorkflowJobIndex when an ordered job name is absent from the map.
Jobs declared as `jobs = [job.test, job.build, job.deploy]` now appear in that exact order in the generated YAML instead of being sorted alphabetically by the generic map serialiser. The parser stores the ref order as a `jobsOrder` sentinel key alongside the `jobs` map in the workflow body. The YAML serialiser (`workflowMapNode`) extracts the sentinel, writes jobs in the declared order via the new `appendOrderedJobsMap` helper, then falls back to sorted order for any jobs not covered. Added a byte-exact snapshot test with three jobs in non-alphabetical order (`test`, `build`, `deploy`) to pin this behaviour.
Go test coverage: 65.0% for commit 8e924c4
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.