Refactoring lyrics_util.py#32
Open
jbarbaran wants to merge 1 commit into
Open
Conversation
…and parser_request modules
Contributor
Author
|
By the way... I forgot to mention before, this PR addresses issue 10! |
yasserror
approved these changes
Oct 21, 2022
Owner
yasserror
left a comment
yasserror
left a comment
There was a problem hiding this comment.
Thanks a lot for the hard work! 😄
Contributor
Author
|
Thank you @MohamedYasser97 I considered using object abstraction but I don't think it is worth it with the current scope of the project. I'm glad I have the opportunity to contribute to the project! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is my first proposal, my main objective has been to separate functionality by concerns and also decrease the number of lines of lyrics_util.py, and at the same time removing code repeated.
Hope you find this interesting!