Lkind check allows for irreducible exciton calculation#224
Lkind check allows for irreducible exciton calculation#224daniele-varsano merged 3 commits intoyambo-code:5.4from
Conversation
|
fine with me to proceed |
|
Just one comment on this point. Instead of having to introduce a new "Lkind", I think it would be more straightforward to define the kernel approximations The main drawback of this alternative is that, so far |
|
I agree it is largely a matter of preference. For me, I'd rather let the user focus on the fact that they are computing different response functions:
The The only important thing is that this information needs to be reported in a database (such as |
|
Added new defaults for
This ensures that the users do not inadvertently calculate the wrong exciton band structure as was previously the case. In addition (as Murali remarked many times), this ensures also that the BSE Hamiltonian is fully symmetric by default. |
|
Why do you say that Lbar is not defined at q different from 0 ? Lbar is well defined and the equation Otherwise (going through Lfull) the relation I say that via Lfull results are worse without coupling/with few eigenvalues because they are in general rather different from the final result with coupling and all eigenvalues. The Lbar case is instead more stable. For these reason, I would not raise an error when running Lbar. Just maybe a warning about symmeties (see next point) About symmetries. I tried on LiF and I get the following.
|
As discussed with Alberto, currently a check at line 166 of
K_driver_initwould not acceptLkind='tilde'as input option for irreducible exciton calculations, although this case is coded below at line 266 of the same file and also documented at input generation viaINIT_load.The change simply recognizes
Lkind='tilde'as an option to switch off the exchange part of the BSE kernel.Also note that
is equivalent - but more straightforward - to