Skip to content

fix(helm): Rename mcp-server port from "mcp" to "mcp-server" for consistency (fixes #2021).#2022

Merged
junhaoliao merged 6 commits intoy-scope:mainfrom
junhaoliao:renaming-helm-mcp-port
Mar 27, 2026
Merged

fix(helm): Rename mcp-server port from "mcp" to "mcp-server" for consistency (fixes #2021).#2022
junhaoliao merged 6 commits intoy-scope:mainfrom
junhaoliao:renaming-helm-mcp-port

Conversation

@junhaoliao
Copy link
Copy Markdown
Member

@junhaoliao junhaoliao commented Feb 24, 2026

Description

Rename the Kubernetes port name for the mcp-server component from "mcp" to "mcp-server" so it follows the same naming convention as every other component in the Helm chart (where the port name matches the component name).

Checklist

  • The PR satisfies the contribution guidelines.
  • This is a breaking change and that has been indicated in the PR title, OR this isn't a
    breaking change.
  • Necessary docs have been updated, OR no docs need to be updated.

Validation performed

Ran helm template against the chart and confirmed:

  • The rendered Deployment manifest shows name: "mcp-server" for the container port.
  • The rendered Deployment manifest shows port: "mcp-server" in the readinessProbe.httpGet and livenessProbe.httpGet sections.
  • The rendered Service manifest shows targetPort: "mcp-server".

Summary by CodeRabbit

  • Chores
    • Updated Helm chart version to 0.2.1-dev.4.
    • Standardized mcp-server port naming across deployment, health checks and service configuration to ensure consistent port references.

@junhaoliao junhaoliao requested a review from a team as a code owner February 24, 2026 14:13
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Feb 24, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro

Run ID: f8ba722a-3e13-45a3-b7e3-4c585dc7fac4

📥 Commits

Reviewing files that changed from the base of the PR and between 0b5ea1a and a04e344.

📒 Files selected for processing (2)
  • tools/deployment/package-helm/Chart.yaml
  • tools/deployment/package-helm/templates/mcp-server-deployment.yaml

Walkthrough

Helm chart version incremented from 0.2.1-dev.3 to 0.2.1-dev.4, and the mcp-server port label was renamed from "mcp" to "mcp-server" in the deployment and Service templates for naming consistency.

Changes

Cohort / File(s) Summary
Chart metadata
tools/deployment/package-helm/Chart.yaml
Chart version updated from 0.2.1-dev.30.2.1-dev.4.
Kubernetes templates
tools/deployment/package-helm/templates/mcp-server-deployment.yaml, tools/deployment/package-helm/templates/mcp-server-service.yaml
Renamed container port name from "mcp""mcp-server", updated readinessProbe httpGet.port reference, and updated Service targetPort to "mcp-server".

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Possibly related issues

  • Port naming consistency for mcp-server Kubernetes manifests: updated port label across deployment and service templates from mcp to mcp-server.
🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The pull request title clearly and specifically summarizes the main change: renaming the mcp-server port from 'mcp' to 'mcp-server' for consistency, and references the related issue.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@kirkrodrigues
Copy link
Copy Markdown
Member

@junhaoliao Can we resolve the conflicts?

apiVersion: "v2"
name: "clp"
version: "0.2.0-dev.1"
version: "0.2.0-dev.3"
Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

assuming #2050 will be merged first

@junhaoliao junhaoliao added this to the March 2026 milestone Mar 7, 2026
# Conflicts:
#	tools/deployment/package-helm/Chart.yaml
@junhaoliao junhaoliao requested review from kirkrodrigues and removed request for kirkrodrigues March 25, 2026 03:37
@junhaoliao junhaoliao merged commit 3653901 into y-scope:main Mar 27, 2026
23 checks passed
@junhaoliao junhaoliao deleted the renaming-helm-mcp-port branch March 27, 2026 20:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants