docs: Clarify that clp-config.yaml changes require a full service restart (resolves #1795).#1945
docs: Clarify that clp-config.yaml changes require a full service restart (resolves #1795).#1945junhaoliao wants to merge 2 commits intoy-scope:mainfrom
clp-config.yaml changes require a full service restart (resolves #1795).#1945Conversation
clp-config.yaml changes require a full service restart (fixes #1795).clp-config.yaml changes require a full service restart (resolves #1795).
WalkthroughUpdated documentation in two quick-start guides to clarify that clp-config.yaml changes require restarting CLP rather than hot-reloading. Replaced vague instructions with explicit guidance to run sbin/stop-clp.sh followed by sbin/start-clp.sh. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Possibly related issues
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Fix all issues with AI agents
In `@docs/src/user-docs/quick-start/clp-text.md`:
- Around line 32-35: Replace the awkward lead-in "Keep in mind about
`etc/clp-config.yaml`:" with a clearer phrase—either "Keep in mind the following
about `etc/clp-config.yaml`:" or simply "Keep in mind:"—so the note reads
naturally before the bullet points; update the sentence containing the exact
text "Keep in mind about `etc/clp-config.yaml`" in clp-text.md accordingly.
| Keep in mind about `etc/clp-config.yaml`: | ||
| - If CLP fails to start (e.g., due to a port conflict), try adjusting the settings and restarting. | ||
| - Configuration changes are **not** hot-reloaded. You must run `sbin/stop-clp.sh` followed by | ||
| `sbin/start-clp.sh` for changes to take effect. |
There was a problem hiding this comment.
Tighten the note lead‑in wording for clarity.
“Keep in mind about …” is awkward; consider “Keep in mind:” or “Keep in mind the following about …”.
🤖 Prompt for AI Agents
In `@docs/src/user-docs/quick-start/clp-text.md` around lines 32 - 35, Replace the
awkward lead-in "Keep in mind about `etc/clp-config.yaml`:" with a clearer
phrase—either "Keep in mind the following about `etc/clp-config.yaml`:" or
simply "Keep in mind:"—so the note reads naturally before the bullet points;
update the sentence containing the exact text "Keep in mind about
`etc/clp-config.yaml`" in clp-text.md accordingly.
Description
Extend the existing "Note" admonition in both quick-start guides (
clp-textandclp-json) to clarify that changes toetc/clp-config.yamlare not hot-reloaded and require a fullsbin/stop-clp.sh/sbin/start-clp.shcycle to take effect.The restart clarification is added as a bullet point in the existing Note (which already references
etc/clp-config.yamlfor port conflicts) rather than as a separate admonition, to reduce visualclutter in the "Starting CLP" section.
Checklist
breaking change.
Validation performed
0. Build docs
Task: Verify the docs build successfully.
Command:
Output:
1. Verify clp-json quick-start page
Served the docs locally and opened the clp-json quick-start page in a browser. The "Note" admonition under "Starting CLP" contains two bullet points: one for port-conflict troubleshooting and one clarifying that configuration changes are not hot-reloaded.
2. Verify clp-text quick-start page
Navigated to the clp-text quick-start page. The same merged "Note" admonition is present with identical content.
Summary by CodeRabbit
Documentation
✏️ Tip: You can customize this high-level summary in your review settings.