Conversation
Keep strict DGSEM multipatch behavior unchanged while adding deterministic compatibility-profile diagnostics in permissive mode. Capability checks now report explicit DGSEM diagnostic codes for reversed interface orientation usage and per-interface penalty controls when multipatch descriptors are provided. Adds regression coverage for strict/permissive DGSEM multipatch diagnostics, updates docs with the new compatibility-only diagnostic codes, and marks the OpenSpec task/plan checklist complete. Validated with: uv run pytest tests/formdsl/test_formdsl_assembly.py -k multipatch, uv run pytest tests/formdsl/test_formdsl_assembly.py, openspec validate formdsl-dgsem-multipatch-compatibility-semantics --strict, and make dev.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
unsupported_multipatch_interface) unchangeddgsem_multipatch_compatibility_profiledgsem_unsupported_multipatch_orientationdgsem_unsupported_multipatch_penalty_controlValidation
uv run pytest tests/formdsl/test_formdsl_assembly.py -k multipatchuv run pytest tests/formdsl/test_formdsl_assembly.pyopenspec validate formdsl-dgsem-multipatch-compatibility-semantics --strictmake dev