feat(formdsl): add per-interface multipatch coupling controls#55
Merged
Conversation
Extend multipatch interface descriptors with optional penalty values and apply deterministic precedence where interface penalty overrides global multipatch_penalty fallback for IGA coupling assembly. Effective penalties are now surfaced in interface_lowering metadata to make control application explicit and testable. Adds deterministic parse/validation checks for malformed interface penalties, updates multipatch stress fixtures to exercise interface penalties, and expands regression coverage for override behavior and matrix deltas. OpenSpec tasks/plan are marked complete and docs reflect the new controls. Validated with: uv run pytest tests/formdsl/test_formdsl_assembly.py -k multipatch, uv run pytest tests/evals/test_formdsl_benchmarks.py, uv run pytest tests/test_script_wrappers.py, uv run python scripts/run_formdsl_parity_benchmark.py --resolutions 8 --include-multipatch-stress --allow-fail, openspec validate formdsl-iga-multipatch-interface-controls --strict, and make dev.
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: cbd94e58d2
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Prevent runtime type errors in IGA multipatch coupling when callers construct WeakFormIR directly with non-numeric interface penalty values. WeakFormIR multipatch validation now rejects non-numeric penalty types instead of silently accepting castable strings. Adds regression coverage for parse_form on WeakFormIR with string interface penalty. Validated with: uv run pytest tests/formdsl/test_formdsl_assembly.py -k multipatch and make dev.
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: f9f3ca9116
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Ensure multipatch descriptors that differ only by per-interface penalty still fail deterministic validation when they map to the same canonical interface geometry. This aligns parse-time validation with backend duplicate handling and prevents late assembly failures. Adds regression coverage for duplicate canonical interfaces with differing penalties. Validated with: uv run pytest tests/formdsl/test_formdsl_assembly.py -k multipatch and make dev.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
penaltyto multipatch interface descriptors in IR/parser with deterministic finite-positive validationinterface.penaltyoverrides globalmultipatch_penaltyfallback) and expose effective values ininterface_loweringValidation
uv run pytest tests/formdsl/test_formdsl_assembly.py -k multipatchuv run pytest tests/evals/test_formdsl_benchmarks.pyuv run pytest tests/test_script_wrappers.pyuv run python scripts/run_formdsl_parity_benchmark.py --resolutions 8 --include-multipatch-stress --allow-failopenspec validate formdsl-iga-multipatch-interface-controls --strictmake dev