Skip to content
This repository was archived by the owner on Feb 8, 2023. It is now read-only.

Feature: collect subtask info into yaml format#70

Open
hoarjour wants to merge 1 commit intoxorbitsai:masterfrom
hoarjour:subtask_vis
Open

Feature: collect subtask info into yaml format#70
hoarjour wants to merge 1 commit intoxorbitsai:masterfrom
hoarjour:subtask_vis

Conversation

@hoarjour
Copy link
Copy Markdown

What do these changes do?

Collect subtask graph structure and runtime subtask information

Related issue number

Fixes #xxxx

Check code requirements

  • tests added / passed (if needed)
  • Ensure all linting tests pass, see here for how to run them

Comment thread mars/services/task/supervisor/graph_visualizer.py Outdated
@hoarjour hoarjour requested a review from UranusSeven November 23, 2022 08:23
Comment thread mars/services/task/supervisor/tests/test_task_manager.py Outdated
Comment thread mars/services/task/supervisor/tests/test_task_manager.py Outdated
Comment thread mars/services/task/supervisor/graph_visualizer.py Outdated
Comment thread mars/services/task/supervisor/graph_visualizer.py Outdated
Comment thread mars/services/cluster/api/core.py Outdated
Comment thread mars/services/cluster/api/oscar.py Outdated
Comment thread mars/services/cluster/yaml_dumper.py Outdated
Comment thread mars/services/task/supervisor/graph_visualizer.py Outdated
Comment thread mars/services/cluster/yaml_dumper.py Outdated
Comment thread mars/services/scheduling/worker/execution.py Outdated
Comment thread mars/services/scheduling/worker/execution.py
Comment thread mars/services/subtask/worker/processor.py Outdated
Comment thread mars/services/subtask/worker/processor.py Outdated
Comment thread mars/services/subtask/worker/processor.py
Comment thread mars/services/task/api/oscar.py Outdated
Comment thread mars/services/task/api/oscar.py Outdated
Comment thread mars/services/task/supervisor/processor.py Outdated
Comment thread mars/services/task/supervisor/processor.py Outdated
Comment thread mars/services/task/task_info_collector.py Outdated
Comment thread mars/services/subtask/worker/processor.py Outdated
Comment thread mars/services/task/api/oscar.py Outdated
Comment thread mars/services/task/api/oscar.py Outdated
Comment thread mars/services/task/api/oscar.py Outdated
Comment thread mars/services/task/supervisor/tests/test_task_manager.py Outdated
Comment thread mars/services/task/supervisor/tests/test_task_manager.py Outdated
Comment thread mars/services/task/task_info_collector.py

class TaskInfoCollectorActor(mo.Actor):

def __init__(self):
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Try this:

mars_temp_dir = os.path.dirname(os.environ.get(MARS_LOG_PATH_KEY))
self.yaml_root_dir = os.path.join(mars_temp_dir, "mars_task_infos")

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add logs to tell the yaml locations.

Comment thread mars/services/task/task_info_collector.py Outdated
Comment thread mars/services/task/task_info_collector.py Outdated
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants