Skip to content

core: (attr assembly fmt) add struct directive (pt6)#5905

Open
n-io wants to merge 1 commit into
nicolai/attr-asm-fmt-pt5-params-v2from
nicolai/attr-asm-fmt-pt6-struct-v2
Open

core: (attr assembly fmt) add struct directive (pt6)#5905
n-io wants to merge 1 commit into
nicolai/attr-asm-fmt-pt5-params-v2from
nicolai/attr-asm-fmt-pt6-struct-v2

Conversation

@n-io
Copy link
Copy Markdown
Collaborator

@n-io n-io commented Apr 21, 2026

Add StructDirective that prints parameters as key=value pairs and parses them in any order. Supports struct(params) for all parameters and struct($a, $b) for a subset.

Add StructDirective that prints parameters as key=value pairs and
parses them in any order. Supports struct(params) for all parameters
and struct($a, $b) for a subset.
@n-io n-io self-assigned this Apr 21, 2026
@n-io n-io added the core xDSL core (ir, textual format, ...) label Apr 21, 2026
@n-io n-io marked this pull request as ready for review April 21, 2026 12:37
@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 21, 2026

Codecov Report

❌ Patch coverage is 82.35294% with 9 lines in your changes missing coverage. Please review.
✅ Project coverage is 86.22%. Comparing base (446f866) to head (0bebfa9).

Files with missing lines Patch % Lines
xdsl/irdl/declarative_assembly_format.py 78.94% 5 Missing and 3 partials ⚠️
xdsl/irdl/declarative_assembly_format_parser.py 92.30% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@                         Coverage Diff                         @@
##           nicolai/attr-asm-fmt-pt5-params-v2    #5905   +/-   ##
===================================================================
  Coverage                               86.22%   86.22%           
===================================================================
  Files                                     418      418           
  Lines                                   60214    60265   +51     
  Branches                                 6988     7002   +14     
===================================================================
+ Hits                                    51922    51966   +44     
- Misses                                   6687     6691    +4     
- Partials                                 1605     1608    +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Copy Markdown
Member

@superlopuh superlopuh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like it

@superlopuh
Copy link
Copy Markdown
Member

It would be great to improve the code coverage here also

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

core xDSL core (ir, textual format, ...)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants