Skip to content

core: (attr assembly fmt) add params directive (pt5)#5904

Open
n-io wants to merge 1 commit into
nicolai/attr-asm-fmt-pt4-qualified-v2from
nicolai/attr-asm-fmt-pt5-params-v2
Open

core: (attr assembly fmt) add params directive (pt5)#5904
n-io wants to merge 1 commit into
nicolai/attr-asm-fmt-pt4-qualified-v2from
nicolai/attr-asm-fmt-pt5-params-v2

Conversation

@n-io
Copy link
Copy Markdown
Collaborator

@n-io n-io commented Apr 21, 2026

Add ParamsDirective that captures all parameters of an attribute and prints them comma-separated. Includes _all_param_variables helper in AttrFormatParser, with tests for basic, three-param, and optional cases.

Add ParamsDirective that captures all parameters of an attribute and
prints them comma-separated. Includes _all_param_variables helper in
AttrFormatParser, with tests for basic, three-param, and optional cases.
@n-io n-io self-assigned this Apr 21, 2026
@n-io n-io added the core xDSL core (ir, textual format, ...) label Apr 21, 2026
@n-io n-io changed the title core: (attr assembly fmt) add params directive core: (attr assembly fmt) add params directive (pt5) Apr 21, 2026
@n-io n-io marked this pull request as ready for review April 21, 2026 12:28
@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 21, 2026

Codecov Report

❌ Patch coverage is 92.50000% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 86.22%. Comparing base (72d4a8a) to head (446f866).

Files with missing lines Patch % Lines
xdsl/irdl/declarative_assembly_format_parser.py 76.92% 1 Missing and 2 partials ⚠️
Additional details and impacted files
@@                          Coverage Diff                           @@
##           nicolai/attr-asm-fmt-pt4-qualified-v2    #5904   +/-   ##
======================================================================
  Coverage                                  86.22%   86.22%           
======================================================================
  Files                                        418      418           
  Lines                                      60174    60214   +40     
  Branches                                    6978     6988   +10     
======================================================================
+ Hits                                       51885    51922   +37     
- Misses                                      6685     6687    +2     
- Partials                                    1604     1605    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

core xDSL core (ir, textual format, ...)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant