Skip to content

core: (attr assembly fmt) add qualified directive (pt4)#5903

Open
n-io wants to merge 1 commit into
nicolai/attr-asm-fmt-pt3-optional-groups-v2from
nicolai/attr-asm-fmt-pt4-qualified-v2
Open

core: (attr assembly fmt) add qualified directive (pt4)#5903
n-io wants to merge 1 commit into
nicolai/attr-asm-fmt-pt3-optional-groups-v2from
nicolai/attr-asm-fmt-pt4-qualified-v2

Conversation

@n-io
Copy link
Copy Markdown
Collaborator

@n-io n-io commented Apr 21, 2026

Add QualifiedParameterVariable (no-op in xdsl since print_attribute always qualifies) and parse_qualified_directive for MLIR format compatibility.

Add QualifiedParameterVariable (no-op in xdsl since print_attribute
always qualifies) and parse_qualified_directive for MLIR format
compatibility.
@n-io n-io self-assigned this Apr 21, 2026
@n-io n-io added the core xDSL core (ir, textual format, ...) label Apr 21, 2026
@n-io n-io marked this pull request as ready for review April 21, 2026 12:28
@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 21, 2026

Codecov Report

❌ Patch coverage is 87.50000% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 86.22%. Comparing base (d122c60) to head (72d4a8a).

Files with missing lines Patch % Lines
xdsl/irdl/declarative_assembly_format_parser.py 83.33% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@                             Coverage Diff                              @@
##           nicolai/attr-asm-fmt-pt3-optional-groups-v2    #5903   +/-   ##
============================================================================
  Coverage                                        86.22%   86.22%           
============================================================================
  Files                                              418      418           
  Lines                                            60166    60174    +8     
  Branches                                          6977     6978    +1     
============================================================================
+ Hits                                             51878    51885    +7     
  Misses                                            6685     6685           
- Partials                                          1603     1604    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

core xDSL core (ir, textual format, ...)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant