Add constructor from TS to TS. Add Base.copy and Base.similar with the DataFrame semantics.#34
Open
Emmanuel-R8 wants to merge 6 commits into
Open
Add constructor from TS to TS. Add Base.copy and Base.similar with the DataFrame semantics.#34Emmanuel-R8 wants to merge 6 commits into
Emmanuel-R8 wants to merge 6 commits into
Conversation
chiraganand
requested changes
May 18, 2022
| struct TS | ||
|
|
||
| coredata :: DataFrame | ||
| coredata::DataFrame |
Member
There was a problem hiding this comment.
Please commit formatting changes such as space removals in a separate PR. It gets difficult to review the diffs.
|
|
||
| ``` | ||
| """ | ||
| Base.similar(ts::TS, rows::Integer=nrow(ts)) = TS(similar(ts.coredata, rows)) |
Member
There was a problem hiding this comment.
Can you change similar(ts.coredata, ...) to use DataFrames.similar()? This is to avoid conflicts if both packages are loaded into REPL.
Emmanuel-R8
commented
May 19, 2022
Contributor
Author
Emmanuel-R8
left a comment
Emmanuel-R8
left a comment
There was a problem hiding this comment.
Formatting changes reverted. similar -> DataFrames::similar
|
@chiraganand @codetalker7 are Base.copy and Base.similar required? Either close PR or review and suggest changes to be merged. |
takaymmt
added a commit
to takaymmt/TSFrames.jl
that referenced
this pull request
Apr 4, 2026
Bug fixes: - _fill_period_gaps: validate fill_gaps symbols against _VALID_FILL_SYMBOLS, throw ArgumentError for unknown strategies (e.g. :bogus) - _apply_interpolate_gaps!: widen guard from AbstractFloat to Number, use round(ElemT, ...) for Int columns — fixes silent skip of integer cols - _apply_interpolate_gaps!: add denom==0 guard for duplicate timestamps, fall back to left anchor instead of producing Inf/NaN - resample(): validate fill_limit >= 1 in all three overloads, throw ArgumentError for fill_limit=0 or negative values Code quality: - Rename local T → ElemT in _apply_interpolate_gaps! (shadows convention) - Use combined[!, :Index] column vector for is_gap mask (avoid row-wise access) Tests (248 pass, +20 new): - Testset xKDR#30: @test_throws ArgumentError for invalid fill_gaps symbols - Testset #27b: :interpolate and constant fill preserve pre-existing missing - Testset xKDR#31: fill_limit=0 and fill_limit=-1 throw ArgumentError - Testset xKDR#32: :ffill fills mid-series gap (Feb between Jan+Mar) - Testset xKDR#33: fill_limit ignored for :zero/:interpolate strategies - Testset xKDR#34: :interpolate with Int column uses round() (Feb=152) Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.