Rebrand APIM Docs#11329
Conversation
📝 WalkthroughOverviewThis pull request makes adjustments to the header styling in the WSO2 API Manager documentation material theme to improve the visual alignment and appearance of header elements. ChangesFile Modified: CSS Styling Updates:
Impact: These changes refine the header layout and spacing of the documentation homepage, ensuring proper alignment of key header components including the logo and topic title. WalkthroughThis pull request modifies the Material theme header stylesheet to adjust layout spacing and positioning. The 🚥 Pre-merge checks | ✅ 3 | ❌ 2❌ Failed checks (1 warning, 1 inconclusive)
✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Tip 💬 Introducing Slack Agent: The best way for teams to turn conversations into code.Slack Agent is built on CodeRabbit's deep understanding of your code, so your team can collaborate across the entire SDLC without losing context.
Built for teams:
One agent for your entire SDLC. Right inside Slack. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
🧹 Nitpick comments (1)
en/theme/material/assets/css/partials/_header.css (1)
41-55: 💤 Low valueConsider extracting the repeated
-14pxoffset into a CSS custom property.The value
-14pxnow appears on both lines 45 and 54. The file already uses CSS custom properties for all other configurable header values (e.g.,--md-header-min-height,--md-header-links-vertical-spacing). Centralising this offset in the:rootblock would keep it consistent with that pattern and make future tweaks a single-line change.♻️ Proposed refactor
Add to the
:rootblock (lines 19–29)::root, [data-md-color-scheme=default] { --md-header-box-shadow: none; --md-header-min-height: 62px; --md-header-link-font-size: .7rem; --md-header-link-font-weight: 400; --md-header-link-opacity: 1; --md-header-link-icon-size: 20px; --md-header-tabs-mobile-breakpoint: 70.1875em; --md-header-links-vertical-spacing: 15px; + --md-header-topic-left-offset: -14px; }Then update the two rules:
.md-header__topic { font-size: .8rem; position: relative; top: -2px; - left: -14px; + left: var(--md-header-topic-left-offset); transform: none !important; opacity: 1 !important; } .md-header__topic:first-child { font-weight: 400; display: block !important; position: relative !important; - left: -14px; + left: var(--md-header-topic-left-offset); }🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@en/theme/material/assets/css/partials/_header.css` around lines 41 - 55, Extract the repeated -14px into a CSS custom property in :root (e.g., --md-header-topic-offset) and replace the hardcoded left: -14px in the .md-header__topic and .md-header__topic:first-child rules with left: var(--md-header-topic-offset); ensure any !important remains if needed and match existing naming patterns for header variables.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Nitpick comments:
In `@en/theme/material/assets/css/partials/_header.css`:
- Around line 41-55: Extract the repeated -14px into a CSS custom property in
:root (e.g., --md-header-topic-offset) and replace the hardcoded left: -14px in
the .md-header__topic and .md-header__topic:first-child rules with left:
var(--md-header-topic-offset); ensure any !important remains if needed and match
existing naming patterns for header variables.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: 69af6840-93d5-4aa0-8b28-bebce033dd7b
⛔ Files ignored due to path filters (3)
en/theme/material/assets/images/favicon.pngis excluded by!**/*.pngen/theme/material/assets/images/logo-for-light.svgis excluded by!**/*.svgen/theme/material/assets/images/logo.svgis excluded by!**/*.svg
📒 Files selected for processing (1)
en/theme/material/assets/css/partials/_header.css
This pull request makes minor adjustments to the header styling in the material theme CSS. The changes primarily involve tweaking the horizontal positioning of header elements and adding a style rule for the logo button.
Header positioning adjustments:
leftoffset from-8pxto-14pxfor certain header elements to improve alignment. [1] [2]Logo button styling:
margin-right: 0for the.md-header__button.md-logoclass, ensuring the logo button aligns properly in the header.