-
Notifications
You must be signed in to change notification settings - Fork 627
Update security instructions for API-M web portals #11249
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
|
|
@@ -32,24 +32,7 @@ session_timeout = "30m" | |||||
|
|
||||||
| ## Restricting access to web portals | ||||||
|
|
||||||
| You can restrict access to the management console of the API-M runtime by binding the management console with selected IP addresses. Note that you can either restrict access to the management console only, or you can restrict access to all web portals as explained below. | ||||||
|
|
||||||
| - To control access only to the management console, add the following configuration to the `<API-M_HOME>/repository/conf/deployment.toml` file: | ||||||
|
|
||||||
| ```toml | ||||||
| [admin_console.control_access] | ||||||
| enable = true | ||||||
| allow = ["IP1", "IP2", "IP3"] | ||||||
| ``` | ||||||
|
|
||||||
| This adds a `RemoteAddrValve` Tomcat valve in the `<API-M_HOME>/repository/conf/tomcat/carbon/META-INF/context.xml` file and it will only apply to the Carbon management console, and thereby all outside requests to the management console will be blocked. | ||||||
|
|
||||||
| <html> | ||||||
| <div class="admonition note"> | ||||||
| <p class="admonition-title">Note</p> | ||||||
| <p>When you enable access control for the management console, only the IP addresses specified in the <code>allow</code> parameter will have access. All other IP addresses will be blocked. Make sure to include all IP addresses that require access to the management console in the whitelist.</p> | ||||||
| </div> | ||||||
| </html> | ||||||
| You can restrict access to the management console of the API-M runtime by binding the management console with selected IP addresses. Note that you can restrict access to all web portals as explained below. | ||||||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Clarify Line 35 to avoid implying an unsupported console-only setting. Line 35 still reads like there is a direct management-console IP-binding option. To align with the documented supported methods, rephrase to explicitly point to the configurations below. Proposed wording update-You can restrict access to the management console of the API-M runtime by binding the management console with selected IP addresses. Note that you can restrict access to all web portals as explained below.
+You can restrict access to API-M web portals, including management console endpoints, using the supported access-control configurations described below.As per coding guidelines: "Provide concise, actionable feedback focused on correctness and best practices." 📝 Committable suggestion
Suggested change
🤖 Prompt for AI Agents |
||||||
|
|
||||||
| - To control access to all web applications deployed in your server, add the following configuration to the `<API-M_HOME>/repository/conf/deployment.toml` file: | ||||||
|
|
||||||
|
|
||||||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This introductory sentence still says access can be restricted to the management console by binding it to selected IPs, but the management-console-only mechanism ([admin_console.control_access]) was removed in this PR. As written, it’s misleading because the only remaining options shown are global web-app access control and per-servlet filtering. Reword this sentence to describe the supported mechanisms (restrict all web apps or specific servlet URLs), without implying a management-console-only binding option.