Respect doing_cron transient in wp cron event run --due-now#130
Draft
Respect doing_cron transient in wp cron event run --due-now#130
doing_cron transient in wp cron event run --due-now#130Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Co-authored-by: swissspidy <841956+swissspidy@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Add no-doubles flag for wp cron event run
Respect Mar 15, 2026
doing_cron transient in wp cron event run --due-now
swissspidy
reviewed
Mar 15, 2026
swissspidy
reviewed
Mar 15, 2026
Co-authored-by: Pascal Birchler <pascal.birchler@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When
--due-nowruns take longer than the invocation interval, the next invocation sees the same in-flight events still in the DB and executes them a second time — duplicating emails, etc.Changes
src/Cron_Event_Command.php— mirrors WordPress core'swp-cron.phplock pattern inrun()when--due-nowis used:doing_crontransient; if fresh (withinWP_CRON_LOCK_TIMEOUT, default 60 s), emits a warning and returns earlyset_transient( 'doing_cron', … )before running eventsdelete_transient( 'doing_cron' )after completion (or before an early error exit)features/cron-event.feature— new scenario covering the transient lock behaviour: sets the transient to simulate a concurrent run, asserts the warning fires and no events execute, then clears the transient and confirms normal execution resumesWarning
Firewall rules blocked me from connecting to one or more addresses (expand for details)
I tried to connect to the following addresses, but was blocked by firewall rules:
api.wordpress.org/usr/bin/curl curl -s REDACTED(dns block)downloads.wordpress.org/usr/bin/curl curl -sSfL REDACTED -main/dist/ripgrep/bin/linux-x64/rg(dns block)/usr/bin/curl curl -sSfL REDACTED(dns block)If you need me to access, download, or install something from one of these locations, you can either:
Original prompt
💬 Send tasks to Copilot coding agent from Slack and Teams to turn conversations into code. Copilot posts an update in your thread when it's finished.