Reject malformed 32-bit constants in AND/XOR and SHA256 compilation [LASuggestion3]#374
Open
Reject malformed 32-bit constants in AND/XOR and SHA256 compilation [LASuggestion3]#374
Conversation
Collaborator
rose2221
commented
Mar 22, 2026
- Add 32-bit width assertions before as u32 truncation in process_binop_opcode (3 sites) to reject constants exceeding 32 bits at compile time instead of silently truncating
- Add matching assertion in cow_to_digit in binops.rs for self-contained validation independent of callers
- Add 32-bit width assertion in sha256_compression.rs for hash value constants used in the optimization path
- Refactor all assertion sites to bind into_bigint() once and reuse, avoiding redundant Montgomery-to-integer conversions
Collaborator
|
Consider adding a #[test] (e.g. in binops.rs) that constructs a ConstantOrR1CSWitness::Constant with a value exceeding 32 bits and asserts the assertion fires via #[should_panic]. |
…ops, noir_to_r1cs, and sha256_compression
00c1e70 to
9555201
Compare
Bisht13
approved these changes
Mar 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.