fix: binop width selection to preserve byte semantics [LA-D]#370
Open
fix: binop width selection to preserve byte semantics [LA-D]#370
Conversation
rose2221
changed the title
Bisht13
requested changes
Mar 22, 2026
provekit/r1cs-compiler/src/binops.rs
Outdated
Collaborator
There was a problem hiding this comment.
Convert this debug_assert! to assert! and update the logic.
Bisht13
approved these changes
Mar 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
get_optimal_binop_widthto only return widths that divide 8 ({2, 4, 8}) instead of the full range[2, 8]. Non-dividing widths (e.g. 3, 5, 6, 7) cause digit decompositions that overallocate bit capacity beyond[0, 255], breaking byte semantics.optimal_binop_width_always_divides_8: verifies the width invariant holds for all input sizes up to 1024.non_canonical_byte_rejected_by_recomposition: regression test confirming that the recomposition constraint rejects non-canonical byte values (> 255) when usingw ∈ {2, 4}.