fix: canonicalize duplicate witness terms in R1CS constraints [LA - C]#354
Open
fix: canonicalize duplicate witness terms in R1CS constraints [LA - C]#354
Conversation
Bisht13
force-pushed
the
px/fix-duplicate-witness-canonicalization-main
branch
2 times, most recently
from
1953b68 to
f6a4f40
Compare
ashpect
changed the title
Bisht13
force-pushed
the
px/fix-duplicate-witness-canonicalization-main
branch
from
f6a4f40 to
af56e43
Compare
Bisht13
force-pushed
the
px/fix-duplicate-witness-canonicalization-main
branch
from
af56e43 to
b48cb38
Compare
rose2221
approved these changes
Mar 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
R1CS::add_constraintbefore inserting into sparse matrices, merging duplicate witness indices (summing coefficients) and dropping zerosdebug_assertinSparseMatrix::setto catch future regressions in debug buildsAddresses audit issue C (Least Authority, March 2026): duplicate witness terms in R1CS constraints silently overwrite coefficients via
SparseMatrix::set, underconstraining the circuit.Test plan
r1cs::tests