Skip to content

feat(kotlin): expose IdentityCheck preset in Kotlin SDK#221

Draft
chipp wants to merge 1 commit into
mainfrom
vladimirburdukov/identity-attributes-kotlin
Draft

feat(kotlin): expose IdentityCheck preset in Kotlin SDK#221
chipp wants to merge 1 commit into
mainfrom
vladimirburdukov/identity-attributes-kotlin

Conversation

@chipp
Copy link
Copy Markdown
Contributor

@chipp chipp commented Apr 21, 2026 •
edited
Loading

Summary

  • Adds identityCheck() top-level helper function to the Kotlin SDK, mirroring the Swift and TS equivalents
  • Re-exports DocumentType and IdentityAttribute as type aliases so consumers don't need to import from uniffi.idkit_core directly
  • Adds unit tests covering the preset construction and legacySignal pass-through
  • Updates the sample app to include an Identity Check option (minimum age 21, nationality JPN, passport)
  • Fixes CI to run Kotlin unit tests and preserves the host library in build-kotlin.sh so JVM tests can load it via jna.library.path
  • Updates kotlin/README.md with a usage snippet

Test plan

  • gradle bindings:test passes locally (runs the two new identityCheck tests)
  • Sample app builds: ./gradlew :app:assembleDebug in kotlin/Examples/IDKitSampleApp
  • CI Kotlin job passes (unit tests + Android build)

@vercel
Copy link
Copy Markdown

vercel Bot commented Apr 21, 2026 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
idkit-js-example Ready Ready Preview, Comment May 20, 2026 11:55am

Request Review

This was referenced Apr 21, 2026
Merged
Draft
Draft
@chipp chipp changed the base branch from vladimirburdukov/identity-attributes to graphite-base/221 April 21, 2026 11:42
@chipp chipp force-pushed the graphite-base/221 branch from ce5b9d7 to 4a76aa5 Compare April 21, 2026 11:43
@chipp chipp force-pushed the vladimirburdukov/identity-attributes-kotlin branch from 9ffdabf to 7a46a6f Compare April 21, 2026 11:43
@chipp chipp changed the base branch from graphite-base/221 to vladimirburdukov/identity-attributes April 21, 2026 11:43
@chipp chipp force-pushed the vladimirburdukov/identity-attributes branch from 4a76aa5 to 6413091 Compare April 21, 2026 11:58
@chipp chipp force-pushed the vladimirburdukov/identity-attributes-kotlin branch from 7a46a6f to 9e0e70e Compare April 21, 2026 11:58
@chipp chipp force-pushed the vladimirburdukov/identity-attributes-kotlin branch from 9e0e70e to f7c4721 Compare April 21, 2026 12:27
@chipp chipp force-pushed the vladimirburdukov/identity-attributes branch from 6413091 to ce6d884 Compare April 21, 2026 12:27
@chipp chipp force-pushed the vladimirburdukov/identity-attributes-kotlin branch from f7c4721 to 946bc69 Compare April 21, 2026 16:39
@chipp chipp force-pushed the vladimirburdukov/identity-attributes branch from ce6d884 to 519e823 Compare April 21, 2026 16:39
@chipp chipp force-pushed the vladimirburdukov/identity-attributes branch from 519e823 to fc81712 Compare April 23, 2026 13:59
@chipp chipp force-pushed the vladimirburdukov/identity-attributes-kotlin branch from 946bc69 to 944c4db Compare April 23, 2026 13:59
@chipp chipp force-pushed the vladimirburdukov/identity-attributes-kotlin branch from 944c4db to 6e2f99b Compare April 23, 2026 14:11
@chipp chipp force-pushed the vladimirburdukov/identity-attributes branch from fc81712 to 35d8ccf Compare April 23, 2026 14:11
@chipp chipp force-pushed the vladimirburdukov/identity-attributes branch from 35d8ccf to eb9e87b Compare April 23, 2026 15:19
@chipp chipp force-pushed the vladimirburdukov/identity-attributes-kotlin branch from 6e2f99b to 60877ab Compare April 23, 2026 15:19
@chipp chipp force-pushed the vladimirburdukov/identity-attributes branch from eb9e87b to f4c67a7 Compare April 23, 2026 15:48
@chipp chipp force-pushed the vladimirburdukov/identity-attributes-kotlin branch from 60877ab to 23fe0f5 Compare April 23, 2026 15:48
@chipp chipp force-pushed the vladimirburdukov/identity-attributes branch from 0e328f0 to 7a61bdc Compare April 30, 2026 19:44
@chipp chipp force-pushed the vladimirburdukov/identity-attributes-kotlin branch from fd4079b to f97922e Compare May 1, 2026 16:34
@chipp chipp force-pushed the vladimirburdukov/identity-attributes branch from 7a61bdc to 961b87a Compare May 1, 2026 16:34
@chipp chipp force-pushed the vladimirburdukov/identity-attributes-kotlin branch from f97922e to c4165d6 Compare May 1, 2026 16:44
@chipp chipp force-pushed the vladimirburdukov/identity-attributes branch from 961b87a to 59cc4a6 Compare May 1, 2026 16:44
@chipp chipp force-pushed the vladimirburdukov/identity-attributes-kotlin branch from c4165d6 to 71b930c Compare May 1, 2026 16:49
@chipp chipp force-pushed the vladimirburdukov/identity-attributes branch from 07ea956 to dcf24dc Compare May 1, 2026 17:06
@chipp chipp force-pushed the vladimirburdukov/identity-attributes-kotlin branch from 71b930c to 734bf27 Compare May 1, 2026 17:06
Base automatically changed from vladimirburdukov/identity-attributes to main May 4, 2026 19:54
@chipp chipp force-pushed the vladimirburdukov/identity-attributes-kotlin branch from 734bf27 to e7b3b2e Compare May 5, 2026 18:22
@chipp chipp force-pushed the vladimirburdukov/identity-attributes-kotlin branch from e7b3b2e to 5e52d9f Compare May 7, 2026 17:21
@chipp chipp force-pushed the vladimirburdukov/identity-attributes-kotlin branch from 5e52d9f to b811f71 Compare May 19, 2026 14:12
@chipp chipp changed the base branch from main to vladimirburdukov/remove-require-proof-of-humanity-from-identitycheck-preset May 19, 2026 14:12
@chipp chipp force-pushed the vladimirburdukov/identity-attributes-kotlin branch from b811f71 to 5026387 Compare May 19, 2026 15:32
@chipp chipp force-pushed the vladimirburdukov/remove-require-proof-of-humanity-from-identitycheck-preset branch from d7f43e2 to 4a938ef Compare May 20, 2026 11:24
@chipp chipp force-pushed the vladimirburdukov/identity-attributes-kotlin branch from 5026387 to 457471c Compare May 20, 2026 11:46
Base automatically changed from vladimirburdukov/remove-require-proof-of-humanity-from-identitycheck-preset to main May 20, 2026 11:49
@chipp chipp force-pushed the vladimirburdukov/identity-attributes-kotlin branch from 457471c to 7884bd1 Compare May 20, 2026 11:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@paolodamico paolodamico Awaiting requested review from paolodamico paolodamico will be requested when the pull request is marked ready for review paolodamico is a code owner

@andy-t-wang andy-t-wang Awaiting requested review from andy-t-wang andy-t-wang will be requested when the pull request is marked ready for review andy-t-wang is a code owner

@SeanROlszewski SeanROlszewski Awaiting requested review from SeanROlszewski SeanROlszewski will be requested when the pull request is marked ready for review SeanROlszewski is a code owner

@Guardiola31337 Guardiola31337 Awaiting requested review from Guardiola31337 Guardiola31337 will be requested when the pull request is marked ready for review Guardiola31337 is a code owner

@Takaros999 Takaros999 Awaiting requested review from Takaros999 Takaros999 will be requested when the pull request is marked ready for review Takaros999 is a code owner

@Gr1dlock Gr1dlock Awaiting requested review from Gr1dlock Gr1dlock will be requested when the pull request is marked ready for review Gr1dlock is a code owner

@murph murph Awaiting requested review from murph murph will be requested when the pull request is marked ready for review murph is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@chipp