Implement support of legacy CredentialCategories request/response#134
Implement support of legacy CredentialCategories request/response#134
Conversation
chipp
requested review from
0x1,
Gr1dlock,
Guardiola31337,
SeanROlszewski,
Takaros999,
andy-t-wang and
paolodamico
as code owners
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
chipp
force-pushed
the
vladimirburdukov-credential-categories-v3-support
branch
from
b1132aa to
b021c9d
Compare
chipp
force-pushed
the
vladimirburdukov-credential-categories-v3-support
branch
from
b021c9d to
afa70f9
Compare
|
@codex review |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: afa70f9514
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
chipp
force-pushed
the
vladimirburdukov-credential-categories-v3-support
branch
from
afa70f9 to
5c9ce32
Compare
Takaros999
left a comment
Takaros999
left a comment
There was a problem hiding this comment.
since we dont have a pattern using this, i would withhold from releasing this to everyone
| case success(IDKitResult) | ||
| case failure(IDKitErrorCode) | ||
| } | ||
| public typealias IDKitCompletionResult = Result<IdKitResult, IDKitErrorCode> |
There was a problem hiding this comment.
is this a breaking change? we need to update our docs if so.
This SDK has already be given to reddit
| /// and from `BridgeResponseV2` (uses `responses`, plural). | ||
| #[derive(Debug, Deserialize)] | ||
| struct BridgeResponseCredentialCategories { | ||
| response: Vec<BridgeCredentialCategoriesProofItem>, |
There was a problem hiding this comment.
nit. You can re-use BridgeResponseV1
| _ => None, | ||
| }; | ||
|
|
||
| let bridge_request_type = match ¶ms.legacy_v1_params { |
There was a problem hiding this comment.
nit. This could an impl method on legacy v1 params to_bridge_protocol
| ) | ||
| } | ||
|
|
||
| fn handle_credential_categories_response( |
There was a problem hiding this comment.
if you reuse BridgeResponseV1::into_response_item() you don't need this
|
closing, can we can reopen if there is a need in the future |
2 participants
Backporting existing functionality from IDKit Swift 3.0
https://github.com/worldcoin/idkit-swift/blob/3b26b4ea543d6e93fca26df17f846f0036c4ac22/Sources/IDKit/Types.swift#L102-L122