fix(compat): walk single-underscore Python module files#78
Merged
Conversation
The Python extractor's file walker skipped any `.py` file starting with `_` (except `__init__.py`), treating them as private modules. workos-python puts every service's public methods in `_resource.py` (re-exported via `__init__.py`), so the walker silently ignored the entire service surface — e.g. PR diffs that removed an Authorization kwarg showed 0 breaking changes for Python while every other language flagged it. Narrow the skip to dunder-prefixed files (`__foo.py`), which matches Python convention for truly name-mangled internals. Single-underscore files now get parsed. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
.pyfile whose name starts with_(except__init__.py), treating them as private. Butworkos-pythonputs every service's public methods in_resource.pyand re-exports them via__init__.py— so the entire service surface was invisible to the differ.Authorization.listResources.searchin openapi-spec#23) showed0breaking changes for Python while every other language correctly flagged them.__foo.py), matching Python's actual convention for name-mangled internals. Single-underscore files now get walked.Test plan
sample-sdk-python/src/workos/widgets/_resource.pyexercises the_resource.pyre-export pattern with a service method that has asearchkwarg.Widgets.list_widgetsand its params are extracted.🤖 Generated with Claude Code