Skip to content

WIP async support#10

Closed
stefanpenner wants to merge 1 commit intoworkmanw:masterfrom
stefanpenner:async
Closed

WIP async support#10
stefanpenner wants to merge 1 commit intoworkmanw:masterfrom
stefanpenner:async

Conversation

@stefanpenner
Copy link
Copy Markdown
Collaborator

@stefanpenner stefanpenner commented Apr 28, 2017

this is still WIP.

Plan:

add async support to the various helpers, so that we can more easily use them in ember-data.

for example:

return assert.expectAssertion(() => {
  return store.somethingThatEventuallyAsserts();
});
  • complete functionality
  • ensure test have been added.

@stefanpenner
Copy link
Copy Markdown
Collaborator Author

I am upstreaming these assertions into ember-qunit. The upstreamed variants include async by default where appropriate.

related ember-test-helpers PRs

When all this lands, my plan is to deprecate this library entirely in-favor of it's assertions simply being officially supported: #29

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant