Skip to content

Remove obsolete docker compose version key#942

Open
kitcommerce wants to merge 1 commit intonextfrom
kit/937-remove-compose-version
Open

Remove obsolete docker compose version key#942
kitcommerce wants to merge 1 commit intonextfrom
kit/937-remove-compose-version

Conversation

@kitcommerce
Copy link
Contributor

Fixes #937

Removes the top-level version: attribute from Compose files to eliminate the version is obsolete warning when running docker compose.

Verification

  • docker compose config >/dev/null
  • docker compose up -d elasticsearch mongo redis

Client impact

None expected.

@kitcommerce kitcommerce added gate:build-pending Build gate running gate:build-passed Build gate passed and removed gate:build-pending Build gate running labels Mar 13, 2026
@kitcommerce kitcommerce force-pushed the kit/937-remove-compose-version branch from 1b4ab01 to 841a7e2 Compare March 13, 2026 08:06
@kitcommerce kitcommerce force-pushed the kit/937-remove-compose-version branch from 1b4ab01 to e210ff7 Compare March 13, 2026 08:06
@kitcommerce kitcommerce added review:architecture-pending Review in progress review:simplicity-pending Review in progress review:security-pending Review in progress review:rails-conventions-pending Rails conventions review in progress review:architecture-done Review complete review:simplicity-done Review complete review:security-done Review complete review:rails-conventions-done Rails conventions review complete merge:ready All conditions met, eligible for merge and removed review:architecture-pending Review in progress review:simplicity-pending Review in progress review:security-pending Review in progress review:rails-conventions-pending Rails conventions review in progress labels Mar 13, 2026
@kitcommerce
Copy link
Contributor Author

Automated Review Wave 1 Results

  • architecture: PASS
  • simplicity: PASS
  • security: PASS
  • rails-conventions: PASS

This PR is config-only (docker-compose yaml). Marking merge:ready.

@kitcommerce kitcommerce added merge:hold In hold window before auto-merge blocked:ci-failing CI/build gate is red and removed merge:ready All conditions met, eligible for merge merge:hold In hold window before auto-merge labels Mar 13, 2026
@kitcommerce
Copy link
Contributor Author

Auto-merge skipped: CI is not fully green (Ruby 3.3 — full test suite failed). Removing merge:ready/merge:hold and marking blocked:ci-failing until CI passes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

blocked:ci-failing CI/build gate is red gate:build-passed Build gate passed review:architecture-done Review complete review:rails-conventions-done Rails conventions review complete review:security-done Review complete review:simplicity-done Review complete

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant