verify: Confirm gemspec required_ruby_version format consistency (WA-VERIFY-080)#1081
Merged
kitcommerce merged 1 commit intonextfrom Mar 17, 2026
Merged
Conversation
… (WA-VERIFY-080) All 5 Workarea gemspecs had required_ruby_version in array form (['>= 2.7.0', '< 3.5.0']) from PR #1050. Convert to canonical single-string form ('>= 2.7.0, < 3.5.0') for consistency. Both forms are semantically equivalent; single-string is the conventional format for gemspec constraints. Fixes #1062
4 tasks
Contributor
Author
Wave 1 Review Resultsarchitecture: PASS — simple formatting normalization across gemspecs; no behavior change intended. Wave 1 PASSED. Ready for Wave 2 / maintainers to merge when convenient. |
kitcommerce
commented
Mar 17, 2026
Contributor
Author
kitcommerce
left a comment
There was a problem hiding this comment.
Wave 2 review (7x) — looks good; no behavior change expected.
{"reviewer":"test-quality","verdict":"PASS","severity":null,"summary":"Pure gemspec metadata normalization; no tests necessary beyond existing CI. ","findings":[]}{"reviewer":"architecture","verdict":"PASS","severity":null,"summary":"No architecture changes; consistent gemspec conventions improve maintainability. ","findings":[]}{"reviewer":"database","verdict":"PASS","severity":null,"summary":"No database impact.","findings":[]}{"reviewer":"security","verdict":"PASS","severity":null,"summary":"No security impact; constraints formatting only.","findings":[]}{"reviewer":"rails-security","verdict":"PASS","severity":null,"summary":"No Rails security impact.","findings":[]}{"reviewer":"simplicity","verdict":"PASS","severity":null,"summary":"Simplifies gemspec constraints representation without changing semantics.","findings":[]}{"reviewer":"rails-conventions","verdict":"PASS","severity":null,"summary":"Single-string required_ruby_version is the common RubyGems convention; notes doc is clear.","findings":[]}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Confirms and fixes
required_ruby_versionformat consistency across all Workarea gemspecs.WA-VERIFY-073 (PR #1050) aligned the constraint value to
>= 2.7.0, < 3.5.0but wrote it in array form. This PR normalizes all gemspecs to the canonical single-string form.Findings
core/workarea-core.gemspec['>= 2.7.0', '< 3.5.0']'>= 2.7.0, < 3.5.0'admin/workarea-admin.gemspec['>= 2.7.0', '< 3.5.0']'>= 2.7.0, < 3.5.0'storefront/workarea-storefront.gemspec['>= 2.7.0', '< 3.5.0']'>= 2.7.0, < 3.5.0'testing/workarea-testing.gemspec['>= 2.7.0', '< 3.5.0']'>= 2.7.0, < 3.5.0'workarea.gemspec['>= 2.7.0', '< 3.5.0']'>= 2.7.0, < 3.5.0'Both forms are semantically equivalent in RubyGems; single-string is the canonical convention for gemspec constraints.
Audit notes:
notes/gemspec-ruby-version-format-verify-2026-03-17.mdClient Impact
None. This is a cosmetic normalization only — the constraint value is unchanged. RubyGems treats both array and single-string forms identically at install time.
Fixes #1062