Narrow broad rescue clauses

admin/app/view_models/workarea/admin/product_rules_preview_view_model.rb

@@ -14,7 +14,7 @@ def self.wrap(model, options = {})
         ].join('::')
 
         view_model_class.constantize.new(model, options)
-      rescue
+      rescue NameError
         new(model, options)
       end
 

core/app/models/workarea/data_file/import.rb

@@ -60,7 +60,7 @@ def process!
         Workarea::Release.with_current(release_id) do
           run_callbacks(:process) { format.import! }
         end
-      rescue Exception => e
+      rescue StandardError => e
         self.error_type = e.class
         self.error_message = e.message
         raise e

core/app/models/workarea/payment/operation.rb

@@ -18,7 +18,7 @@ def success?
       def complete!
         begin
           complete_each_transaction!
-        rescue Exception => e
+        rescue StandardError => e
           rollback!
           raise e
         ensure

core/app/models/workarea/payment/profile.rb

@@ -36,7 +36,7 @@ def self.update_email(reference, new_email)
       #
       def default_credit_card
         credit_cards.find_by(default: true)
-      rescue
+      rescue Mongoid::Errors::DocumentNotFound
         credit_cards.desc(:created_at).first
       end
 

core/app/models/workarea/payment/tender/credit_card.rb

@@ -22,7 +22,7 @@ def tokenized?
 
         def saved_card
           @saved_card ||= profile.credit_cards.find(saved_card_id) if saved?
-        rescue
+        rescue Mongoid::Errors::DocumentNotFound
           nil
         end
 

core/app/models/workarea/product_rule.rb

@@ -53,8 +53,15 @@ def field
     # @return [Comparable]
     #
     def value
-      return Time.zone.parse(value_field) rescue value_field if created_at?
-      value_field
+      if created_at?
+        begin
+          Time.zone.parse(value_field)
+        rescue ArgumentError, TypeError
+          value_field
+        end
+      else
+        value_field
+      end
     end
 
     # This is HACK for the fact that we want a CSV string in value, but our
@@ -134,7 +141,7 @@ def value_is_date_if_field_is_date
       if created_at?
         begin
           Time.zone.parse(value_field)
-        rescue
+        rescue ArgumentError, TypeError
           errors.add(
             :base,
             I18n.t('workarea.errors.messages.not_a_date')

core/app/services/workarea/direct_upload.rb

@@ -77,7 +77,7 @@ def delete!
     def processor
       return @processor if defined?(@processor)
       @processor = "Workarea::DirectUpload::#{@type.camelize}".constantize.new(self)
-    rescue
+    rescue NameError
       @processor = nil
     end
 

core/app/workers/workarea/index_category_changes.rb

@@ -35,7 +35,7 @@ def perform(changes, for_release = false)
         Catalog::Product.in(id: ids).each do |product|
           begin
             IndexProduct.perform(product)
-          rescue
+          rescue StandardError
             IndexProduct.perform_async(product.id)
           end
         end

core/lib/workarea/latest_version.rb

@@ -13,7 +13,7 @@ def self.get
 
         JSON.parse(response.body)['version']
       end
-    rescue Exception => e
+    rescue StandardError => e
       Workarea::ErrorReporting.report(
         e,
         handled: true,

core/lib/workarea/monitoring/mongoid_check.rb

@@ -15,7 +15,7 @@ def database_up?
           .collections
           .find
           .present?
-      rescue
+      rescue StandardError
         false
       end
     end

core/lib/workarea/monitoring/sidekiq_queue_size_check.rb

@@ -8,7 +8,7 @@ def check
 
         [status, "#{status ? 'Low' : 'High'} - #{length}"]
 
-      rescue
+      rescue StandardError
         [false, 'Down']
       end
     end

core/lib/workarea/ping_home_base.rb

@@ -18,7 +18,7 @@ def ping
           http.verify_mode = OpenSSL::SSL::VERIFY_NONE
           http.start { |h| h.request(request) }
 
-        rescue Exception => e
+        rescue StandardError => e
           Workarea::ErrorReporting.report(
             e,
             handled: true,
@@ -61,7 +61,7 @@ def client_id
         return unless File.exist?(Rails.root.join('.client-id'))
 
         File.read(Rails.root.join('.client-id'))
-      rescue
+      rescue StandardError
         nil
       end
 

core/vendor/active_shipping/lib/active_shipping/carriers/canada_post_pws.rb

@@ -137,7 +137,7 @@ def retrieve_merchant_details(options = {})
       parse_merchant_details_response(response)
     rescue ActiveUtils::ResponseError, ActiveShipping::ResponseError => e
       error_response(e.response.body, CPPWSMerchantDetailsResponse)
-    rescue Exception => e
+    rescue StandardError => e
       raise ResponseError.new(e.message)
     end