Fenrir fixes#15
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
aidangarske
reviewed
Apr 29, 2026
Member
aidangarske
left a comment
aidangarske
left a comment
There was a problem hiding this comment.
Skoll Multi-Scan Review
Modes: review + review-security + audit
Overall recommendation: REQUEST_CHANGES
Findings: 6 total — 6 posted, 0 skipped
6 finding(s) posted as inline comments (see file-level comments below)
Posted findings
- [High] [review+review-security] ML-DSA wrapper breaks Dilithium-disabled and partial-level builds —
test/psa_server/psa_api_test.c:4238-4260 - [High] [review+review-security] X448 usability test fails instead of skipping on builds without full Curve448 support —
test/psa_server/psa_api_test.c:3863-3881 - [High] [audit] Modified
psa_hash_clone()still has no in-repo coverage —src/psa_hash_engine.c:817-826 - [Medium] [review+audit] CFB decrypt-setup change has no matching regression coverage —
src/psa_cipher.c:552-555 - [Low] [review] psa_cipher_decrypt_setup: PSA_ALG_CFB appears in two mutually-exclusive branches —
src/psa_cipher.c:545-560 - [Low] [review] psa_engine.c lost blank line between #include block and first function —
src/psa_engine.c:33-35
Review generated by Skoll
aidangarske
approved these changes
Apr 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
F/3426 - Fix OFB decrypt AES key setup (
61cab59)F/3430 - Restrict KDF input keys to DERIVE usageEventually rejected: PSA compliance tests requirePSA_KEY_USAGE_VERIFY_DERIVATION. See Fenrir.F/3427 - Add X448 PSA usability test (
7df9fb3)F/3428 - Add ML-DSA parameter mapping coverage (
d5fe8af)F/3433 - Scrub hash clone cleanup paths (
88e8417)F/3429 - Remove dead psa_engine helpers (
61728f2)