Fix spi_flash_write_page to stop at len or page boundary#690
Merged
dgarske merged 1 commit intowolfSSL:masterfrom Feb 23, 2026
Merged
Fix spi_flash_write_page to stop at len or page boundary#690dgarske merged 1 commit intowolfSSL:masterfrom
dgarske merged 1 commit intowolfSSL:masterfrom
Conversation
+ Added unit tests for spi_flash.c
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes a bug in spi_flash_write_page where the write loop could continue past the requested data length when crossing page boundaries, and adds comprehensive unit tests to verify the fix.
Changes:
- Fixed the page write loop termination condition to respect both length and page boundary constraints
- Added new unit test file with 8 test cases covering write, read, erase, and error scenarios
- Updated build configuration to include the new unit test target
Reviewed changes
Copilot reviewed 3 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/spi_flash.c | Fixed do-while loop to check both len and page boundary before continuing |
| tools/unit-tests/unit-spi-flash.c | Added comprehensive unit tests with SPI mock for testing flash operations |
| tools/unit-tests/Makefile | Added unit-spi-flash to test targets list |
| .gitignore | Organized unit test binary entries with proper section header |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
dgarske
approved these changes
Feb 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ref: Fenrir / M-1