Skip to content

Comments

Fix spi_flash_write_page to stop at len or page boundary#690

Merged
dgarske merged 1 commit intowolfSSL:masterfrom
danielinux:fix_spi_flash_boundary_checks
Feb 23, 2026
Merged

Fix spi_flash_write_page to stop at len or page boundary#690
dgarske merged 1 commit intowolfSSL:masterfrom
danielinux:fix_spi_flash_boundary_checks

Conversation

@danielinux
Copy link
Member

  • Added unit tests for spi_flash.c

Ref: Fenrir / M-1

Copilot AI review requested due to automatic review settings February 23, 2026 16:56
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes a bug in spi_flash_write_page where the write loop could continue past the requested data length when crossing page boundaries, and adds comprehensive unit tests to verify the fix.

Changes:

  • Fixed the page write loop termination condition to respect both length and page boundary constraints
  • Added new unit test file with 8 test cases covering write, read, erase, and error scenarios
  • Updated build configuration to include the new unit test target

Reviewed changes

Copilot reviewed 3 out of 4 changed files in this pull request and generated no comments.

File Description
src/spi_flash.c Fixed do-while loop to check both len and page boundary before continuing
tools/unit-tests/unit-spi-flash.c Added comprehensive unit tests with SPI mock for testing flash operations
tools/unit-tests/Makefile Added unit-spi-flash to test targets list
.gitignore Organized unit test binary entries with proper section header

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@dgarske dgarske merged commit 0a738ac into wolfSSL:master Feb 23, 2026
315 of 316 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants