Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/req/steps.ex
Original file line number Diff line number Diff line change
Expand Up @@ -2032,7 +2032,7 @@ defmodule Req.Steps do

request =
request
|> build_redirect_request(response, location)
|> build_redirect_request(response, URI.encode(location))
|> Req.Request.put_private(:req_redirect_count, redirect_count + 1)

{request, response_or_exception} = Req.Request.run_request(request)
Expand Down
28 changes: 28 additions & 0 deletions test/req/steps_test.exs
Original file line number Diff line number Diff line change
Expand Up @@ -1471,6 +1471,34 @@ defmodule Req.StepsTest do
end
end

test "escapes location", c do
Bypass.expect(c.bypass, "GET", "/redirect", fn conn ->
location =
case conn.query_string do
"" -> "/oh hai?param=with spaces"
string -> "/oh hai?" <> string
end

redirect(conn, 302, location)
end)

Bypass.expect(c.bypass, "GET", "/oh%20hai", fn conn ->
Plug.Conn.send_resp(conn, 200, conn.query_string)
end)

assert ExUnit.CaptureLog.capture_log(fn ->
response = Req.get!(c.url <> "/redirect")
assert response.status == 200
assert response.body == "param=with%20spaces"
end) =~ "[debug] redirecting to /oh%20hai?param=with%20spaces"

assert ExUnit.CaptureLog.capture_log(fn ->
response = Req.get!(c.url <> "/redirect?a=1")
assert response.status == 200
assert response.body == "a=1"
end) =~ "[debug] redirecting to /oh%20hai?a=1"
end

test "without location", c do
Bypass.expect(c.bypass, "POST", "/redirect", fn conn ->
Plug.Conn.send_resp(conn, 303, "")
Expand Down
Loading