fixed dsn connection string format for SQL Server#121
Open
stekoch wants to merge 2 commits intowizacode:masterfrom
Open
fixed dsn connection string format for SQL Server#121stekoch wants to merge 2 commits intowizacode:masterfrom
stekoch wants to merge 2 commits intowizacode:masterfrom
Conversation
Collaborator
|
Thanks! I will look at it soon! |
Collaborator
|
@stekoch I am going to try to fix the issue with the test on master. When done, post a message here so you could add a unit test to cover your work :) |
Collaborator
|
@stekoch That's good now, you can rebase from master. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Using MS SQL server was not possible due to incorrect parameter names being used in the dsn connection string. Fixed those, can now connect to MS SQL Server successfully.