fix(interact): make custom element layout transparent#221
Open
omribz156 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds the default layout-transparent style for
<interact-element>when the custom element is registered.defineInteractElement()now injects oneinteract-element { display: contents; }style element, so wrappers do not participate as inline boxes in grid/flex layout. The style injection is idempotent and still runs if the element was already registered.Related Issue
Fixes #182
Checklist
Screenshots / Demos
Not applicable.
Additional Notes
Verification:
corepack yarn install --immutablecorepack yarn workspace @wix/motion buildcorepack yarn prettier packages\interact\src\web\defineInteractElement.ts packages\interact\test\web.spec.ts --checkcorepack yarn workspace @wix/interact lintcorepack yarn workspace @wix/interact test -- test/web.spec.ts(Vitest ran the package suite: 9 files, 402 tests passed)git diff --checkThis was implemented with Codex assistance, with the patch kept focused on the layout wrapper behavior from the issue.