ci: test interact against React 18 and 19#220
Open
omribz156 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds a focused CI matrix job for
@wix/interactReact compatibility. The existing full build/lint/test job stays unchanged, and the new job only runs the@wix/interacttest suite against React 18 and React 19.The matrix job keeps the base install immutable, builds
@wix/motionfirst so the workspace package entry resolves for tests, then overlays the React/test dependencies for the selected matrix version in the ephemeral CI workspace.Related Issue
Fixes #195
Checklist
Screenshots / Demos
Not applicable.
Additional Notes
Verification:
actionlint .github/workflows/ci.ymlcorepack yarn install --immutablecorepack yarn workspace @wix/motion buildcorepack yarn workspace @wix/interact testwith React 18 dependencies: 401 tests passedcorepack yarn workspace @wix/interact add --dev react@^19.0.0 react-dom@^19.0.0 @types/react@^19.0.0 @types/react-dom@^19.0.0 @testing-library/react@^16.1.0corepack yarn workspace @wix/interact testwith React 19 dependencies: 401 tests passedcorepack yarn prettier .github/workflows/ci.yml --checkgit diff --checkThis was implemented with Codex assistance, with the patch kept focused on the CI coverage requested in the issue.