fix(motion-presets): export public types subpath#218
Open
omribz156 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Bug fix: exposes the existing
@wix/motion-presetstype entry as a public package subpath.packages/motion-presets/vite.config.tsalready builds atypesentry, butpackage.jsononly exported the root module andpackage.json. This adds@wix/motion-presets/types, so consumers can import preset option types without copying internal definitions.Related Issue
Fixes #176
Checklist
Screenshots / Demos
Not applicable.
Additional Notes
Verification:
yarn install --immutablenode -e "...package exports OK"yarn prettier --check packages/motion-presets/package.jsongit diff --check -- packages/motion-presets/package.jsonI also tried
yarn workspace @wix/motion-presets run build:types, but it fails on existing type errors unrelated to this metadata-only change, including unresolved@wix/motionimports and implicitany/ index errors in preset source files.nvm usecould not switch to.nvmrc's22.14.0because that version is not installed locally, so verification used the available Nodev24.15.0.Implemented with Codex assistance; I kept the patch focused and manually reviewed the final diff.