Created root README#213
Conversation
ameerf-wix
left a comment
ameerf-wix
left a comment
There was a problem hiding this comment.
Looks good. A few inaccuracies concerning the need for 'initial' and some of the types.
I am afraid we must have full-path production links in here and not this relative packages/interact/... as those will work only from within the project
| | [`@wix/interact`](https://www.npmjs.com/package/@wix/interact) | 2.2.2 | Declarative interaction layer (main package) | [README](packages/interact/README.md) · [npm](https://www.npmjs.com/package/@wix/interact) | | ||
| | [`@wix/motion`](https://www.npmjs.com/package/@wix/motion) | 2.1.5 | Low-level animation engine | [README](packages/motion/README.md) · [npm](https://www.npmjs.com/package/@wix/motion) | | ||
| | [`@wix/motion-presets`](https://www.npmjs.com/package/@wix/motion-presets) | 1.0.2 | Ready-made animation presets | [npm](https://www.npmjs.com/package/@wix/motion-presets) · [preset rules](packages/motion-presets/rules/presets/presets-main.md) | |
There was a problem hiding this comment.
the npm links are duplicated each - necessary?
There was a problem hiding this comment.
Also you have some links that are not absolute and this will break
There was a problem hiding this comment.
Fixed the URLs.
The duplicate npm links are fine, unless you have a better suggestion for the links to the packages? Would it be better to link to the source on github?
There was a problem hiding this comment.
they are duplicated on the same line, yes? you have a table with every row containing the link to the package npm-page twice.
There was a problem hiding this comment.
maybe linking to github makes sense actually
| ### Rules files | ||
|
|
||
| We welcome contributions! Please see our [Contributing Guide](CONTRIBUTING.md) for details on: | ||
| **@wix/interact** (also on [GitHub Pages /rules/](https://wix.github.io/interact/rules/integration.md)): |
There was a problem hiding this comment.
I don't think it makes sense to link to integration.md here in the title, and then again one line below.
| - For `viewProgress`, avoid `overflow: hidden` on ancestors; use `overflow: clip` instead | ||
| - Call `generate(config)` at build time or on the server and inject CSS into `<head>`. For `viewEnter` + `triggerType: 'once'`, also set `initial` on the element to prevent FOUC | ||
|
|
||
| ### Repository agent context |
There was a problem hiding this comment.
| ### Repository agent context | |
| ### Repository agent context for development |
2 participants
No description provided.