Slide by item#60
Open
josephnvn wants to merge 3 commits into
Open
Conversation
I had this specific requirement where I need to scroll only one item and not the whole screen (or bunch of items on screen). So, I have introduced slideByItem as an optional and updated slideByPages to handle that!
Contributor
|
Nice! Couple of thoughts:
|
Updated the code to address the irregular widths of items.
…t to true Notices that I forgot to update the bullets count! and so the addition... @jamie White : Thanks for the comments Jamie. I have considered the irregular width of items and dropped a fix in previous commit. However I did not change the slideByItem option type to element selector (as you suggested.), because 'li' is what microfiche is taking as an item anyway. Let me know your thoughts!
Contributor
|
Hi @josephnvn Sorry it’s been so long since we last discussed this PR. I still think it looks great. What do you think about applying similar logic to More generally: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I had this specific requirement where I need to scroll only one item and not the whole screen (or bunch of items on screen). So, I have introduced slideByItem as an optional and updated slideByPages to handle that!