fix: Crash on right click of Ownable Entities if owner is offline#389
Open
Aquaeyes wants to merge 1 commit intowisp-forest:1.20.1-Backportfrom
Open
fix: Crash on right click of Ownable Entities if owner is offline#389Aquaeyes wants to merge 1 commit intowisp-forest:1.20.1-Backportfrom
Aquaeyes wants to merge 1 commit intowisp-forest:1.20.1-Backportfrom
Conversation
fixes crash on right clicking dogs if accessories enabled for entity if owner is offline
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Initial solution was to add a null-check, but as player is not set as
nullable, swapping the order seems to work just as well. If player isn't trulynot-null, a null check would suffice too.To reproduce the bug, simply right-clicking any ownable entity with an accessory in-hand, or by attempting to open the entity's Accessories Menu would crash the game to desktop.