Skip to content

build 5.27 #886

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Veki301 wants to merge 2 commits into
base: master
Choose a base branch
from
Open

build 5.27 #886

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
11ead0f
build 5.27
Veki301 Mar 30, 2026
6024475
add logic to skip images, add offending images
Veki301 Mar 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion offline/tasks/proc_pull_charts.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,5 +94,5 @@ pull_charts() {
#fi
}

wire_build="https://raw.githubusercontent.com/wireapp/wire-builds/pinned-offline-multi-20260224-142104/build.json"
wire_build="https://raw.githubusercontent.com/wireapp/wire-builds/d8bdda07fd4c32937a5482711b6e322a32d0c784/build.json"
wire_build_chart_release "$wire_build" | pull_charts
20 changes: 20 additions & 0 deletions offline/tasks/process_charts.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,10 @@ OUTPUT_DIR=""
# Default exclude list
IMAGE_EXCLUDE_LIST=""

# Comma-separated list of chart basenames to skip during image processing
# Use this for upstream charts with untagged/latest images that can't be fixed
HELM_CHART_SKIP_LIST="rust-sft, fluent-bit"
Copy link
Copy Markdown
Contributor

@mohitrajain mohitrajain Mar 30, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is the use of this HELM_CHART_SKIP_LIST, do we want to ship the helm chart but without image?
we already have a PR for 5.27, why do we need to release a new one? #876


# Default values type will expect to use prod values
VALUES_TYPE="prod"

Expand All @@ -21,6 +25,9 @@ do
IMAGE_EXCLUDE_LIST=*)
IMAGE_EXCLUDE_LIST="${arg#*=}"
;;
HELM_CHART_SKIP_LIST=*)
HELM_CHART_SKIP_LIST="${arg#*=}"
;;
*)
echo "Unknown argument: $arg" >&2
exit 1
Expand All @@ -46,6 +53,19 @@ echo "Excluding images matching the pattern: $EXCLUDE_PATTERN"
# Get and dump required containers from Helm charts. Omit integration test
# containers (e.g. `quay.io_wire_galley-integration_4.22.0`.)
for chartPath in "${OUTPUT_DIR}"/charts/*; do
chartName=$(basename "$chartPath")
if [[ -n "$HELM_CHART_SKIP_LIST" ]]; then
IFS=',' read -ra skip_arr <<< "$HELM_CHART_SKIP_LIST"
skip=false
for skip_chart in "${skip_arr[@]}"; do
if [[ "$chartName" == "$skip_chart" ]]; then
echo "Skipping chart $chartName (in HELM_CHART_SKIP_LIST)" >&2
skip=true
break
fi
done
[[ "$skip" == true ]] && continue
fi
echo "$chartPath"
done | list-helm-containers VALUES_DIR="${OUTPUT_DIR}"/values HELM_IMAGE_TREE_FILE="$HELM_IMAGE_TREE_FILE" VALUES_TYPE="$VALUES_TYPE" | grep -v "\-integration:" > "${OUTPUT_DIR}"/images

Expand Down
Loading