Remove unused VIP template file#27
Merged
Merged
Conversation
- Deleted templates/cpnetwork.yaml.tmpl (no longer used after VIP removal) - Updated README directory structure to remove reference to deleted file - Cleanup following VIP configuration removal in PR #25
- Deleted templates/worker-disks.yaml.tmpl (contained empty disk array) - Removed config_patches references from all three worker configuration apply resources - Updated README to remove templates directory (no templates remain) - Longhorn disks are managed manually via UI, not pre-configured
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Cleanup PR to remove the unused VIP configuration template file following the VIP removal in PR #25.
Changes
Context
The VIP (Virtual IP) configuration was removed in PR #25 due to a network mismatch between the VIP address (192.168.3.180) and the cluster network (10.0.0.0/24). The template was used for this configuration and is no longer needed.
This cleanup ensures the repository only contains actively used files.