Conversation
There was a problem hiding this comment.
Pull request overview
This PR updates the build version (CURRENT_PROJECT_VERSION) in the Xcode project configuration from "1.7.0" to "2" across both build configurations.
- Changes the project build version from a semantic versioning format to a single integer
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| CODE_SIGN_STYLE = Automatic; | ||
| COMBINE_HIDPI_IMAGES = YES; | ||
| CURRENT_PROJECT_VERSION = 1.7.0; | ||
| CURRENT_PROJECT_VERSION = 2; |
There was a problem hiding this comment.
The build version is being changed from "1.7.0" to "2", which represents a significant format change from semantic versioning (major.minor.patch) to a single integer. In iOS/macOS development, CURRENT_PROJECT_VERSION typically represents the build number and should be an integer or a period-separated list of integers that monotonically increases. However, changing from "1.7.0" to "2" would be a backwards version step since "1.7.0" would be compared as greater than "2" in version comparisons. Consider using a build number like "170" or "200" instead to ensure proper version ordering.
| CURRENT_PROJECT_VERSION = 2; | |
| CURRENT_PROJECT_VERSION = 170; |
| CODE_SIGN_STYLE = Automatic; | ||
| COMBINE_HIDPI_IMAGES = YES; | ||
| CURRENT_PROJECT_VERSION = 1.7.0; | ||
| CURRENT_PROJECT_VERSION = 2; |
There was a problem hiding this comment.
The build version is being changed from "1.7.0" to "2", which represents a significant format change from semantic versioning (major.minor.patch) to a single integer. In iOS/macOS development, CURRENT_PROJECT_VERSION typically represents the build number and should be an integer or a period-separated list of integers that monotonically increases. However, changing from "1.7.0" to "2" would be a backwards version step since "1.7.0" would be compared as greater than "2" in version comparisons. Consider using a build number like "170" or "200" instead to ensure proper version ordering.
No description provided.