Conversation
Signed-off-by: pyranota <pyra@duck.com>
Deploying windmill with
|
| Latest commit: |
f40a3b4
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://919b1d1a.windmill.pages.dev |
| Branch Preview URL: | https://debouncing-tests.windmill.pages.dev |
|
Claude finished @pyranota's task in 1m 19s —— View job
Review SummaryThis PR significantly improves the workspace dependencies test suite — well structured and thorough. The tests are well-organized into logical sections (CRUD, versioning, workspace isolation, language-specific, path generation, E2E) with clear doc comments explaining intent. Key improvements:
One minor issue found:
Overall: Looks good. The test coverage is comprehensive and the code is clean. Reproduction instructionsThese are backend integration tests for workspace dependencies. To verify: navigate to the Windmill workspace settings page, go to the "Dependencies" section where you can create named/unnamed workspace dependencies for different languages (Python, Bun/TypeScript, PHP). Creating or updating a workspace dependency should trigger re-lock jobs for all scripts that reference it via the dependency map. Hub-synced scripts (like |
| } | ||
| "##; | ||
|
|
||
| #[allow(dead_code)] |
There was a problem hiding this comment.
PACKAGE_JSON_V2 is marked #[allow(dead_code)] but it's actively used in test_versioning_archives_previous, test_description_inheritance, and test_workspace_isolation. This attribute should be removed.
| #[allow(dead_code)] | |
| pub const PACKAGE_JSON_V2: &'static str = r##" |
No description provided.