Skip to content

fix: prevent path editor reload and layout shift in summary popover#8183

Draft
Guilhem-lm wants to merge 1 commit intomainfrom
glm/fix-path-editor-loading-state
Draft

fix: prevent path editor reload and layout shift in summary popover#8183
Guilhem-lm wants to merge 1 commit intomainfrom
glm/fix-path-editor-loading-state

Conversation

@Guilhem-lm
Copy link
Copy Markdown
Contributor

Summary

Fix two issues in the SummaryPathDisplay popover related to the Path component.

Changes

  • Wrap $effect body in untrack() so only popoverOpen is tracked — prevents the Path component from reinitializing on every keystroke in the summary input
  • Add a fixed-height placeholder with inline loader in Path.svelte while meta is loading, preventing layout shift when the path editor appears

Test plan

  • Open a flow/script, click the summary/path area to open the popover
  • Type in the summary input — the path editor should NOT reload
  • Verify the popover does not shift when the path editor loads

Generated with Claude Code

@cloudflare-workers-and-pages
Copy link
Copy Markdown

Deploying windmill with  Cloudflare Pages  Cloudflare Pages

Latest commit: 18a0d49
Status: ✅  Deploy successful!
Preview URL: https://70d93022.windmill.pages.dev
Branch Preview URL: https://glm-fix-path-editor-loading.windmill.pages.dev

View logs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant